Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kata containers #4347

Closed
tstromberg opened this issue May 24, 2019 · 21 comments
Closed

Add support for Kata containers #4347

tstromberg opened this issue May 24, 2019 · 21 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@tstromberg
Copy link
Contributor

Similar to the gvisor addon included in minikube, minikube should also add support for https://katacontainers.io/

The use of nested VM's might cause compatibility issues for some hypervisors, but if any incompatibilities are discovered, should can just identify those and error out. Similar to how gvisor errors out if a non-containerd runtime is requested.

Help wanted!

@tstromberg tstromberg added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. roadmap/2019 Items on the 2019 roadmap kind/feature Categorizes issue or PR as related to a new feature. labels May 24, 2019
@tstromberg
Copy link
Contributor Author

Related PR: #4340

@amshinde
Copy link
Contributor

@priyawadhwa I see that you added support for gvisor addon, can you provide some guidance for what would be required to do the same for Kata.
I had a look at your PR for adding gvisor support, and a lot of the setup for Kata is done with kata-deploy component that we have come up with. Document for setting up kata with minikube and kata-deploy can be found here : kata-containers/documentation#445

@tstromberg
Copy link
Contributor Author

@priyawadhwa is on holiday this week, but will be back next week sometime.

Also, we plan to release minikube v1.1.1 once Kubernetes v1.14.3 is available in roughly a week. This should include #4340 which will make life easier. We're open to any and all suggestions on how to make minikube easier for Kata to work with.

@tstromberg
Copy link
Contributor Author

@grahamwhaley @amshinde @egernst - Is there anything we can be doing from the minikube side to make it easier to support Kata? I'm really eager to see Kata get built-in and would be happy to help get the ball rolling any way that I can.

Also, if someone would like this issue to be assigned to them, just say the word.

I'm at KubeCon Shanghai today in case any Kata folks would like to speak further in person.

@egernst
Copy link

egernst commented Jun 26, 2019

/cc @wangxu @bergwolf - they are at KubeCon as well.

@bergwolf
Copy link

@tstromberg @egernst Sorry just saw this and Kubecon Shanghai has ended several hours ago. IIRC we need some addition to minikube's kernel config to support kata containers. @grahamwhaley has done some work enabling minikube+kata before. Could you share your steps/changes?

@grahamwhaley
Copy link

@bergwolf - kernel config was done over on #4340 - kata-deploy and kata work with minikube today - but, you have to install them yourselves. On this ticket we are discussing adding kata as a first class citizen to minikube, so it can be installed with the minikube installer, like gvisor can with minikube today.

afaiu, what we need to do is assess how near kata-deploy is to the method used for gvisor (they look similar), and get down and do the work :-) Available engineering time is the main blocker right now - it just has not trickled up to the top of anybodies 'todo' list yet.. (it is on my list, but not at the top I'm afraid :-( )

@tstromberg
Copy link
Contributor Author

@gramahwhaley - Thanks for the update! Please feel free to chase me down if you have any questions.

@tstromberg
Copy link
Contributor Author

Just checking in to see if there is anything I can to do to help this feature come into fruition. Thanks!

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 31, 2019
@egernst
Copy link

egernst commented Oct 31, 2019

@grahamwhaley - any interest in picking this up?

@grahamwhaley
Copy link

well, yes, it interests me to fix, but I'm not sure it will ever reach the top of my todo pile :-(

@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 30, 2019
@grahamwhaley
Copy link

@egernst - were you trying to pick this up recently? Any updates or preliminary data?

@sharifelgamal sharifelgamal removed the roadmap/2019 Items on the 2019 roadmap label Dec 16, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@medyagh medyagh reopened this Mar 7, 2020
@medyagh
Copy link
Member

medyagh commented Mar 7, 2020

is there still interest to do this ?
@afbjorklund
@tstromberg grahamwhaley

@afbjorklund
Copy link
Collaborator

@medyagh : not interested, sorry

@grahamwhaley
Copy link

iirc, the last discussion @egernst and I had centered around the fact that Kata is still developing reasonably fast, and we were mildly concerned that any direct kata-integration might rot and go stale/out of date pretty fast. If we based the integration around a pull/install of kata-deploy that would probably help, but then I'd really like to have minikube/kata up and running in a CI somewhere (either minikube or Kata) so we could detect any divergence and breakage before it ended up with end users...

Ultimately, the kata minikube install guide exists today. I would really like to see a Kata/minikube CI still, as occasionally we (I) do have to go fix the integration as things move on, and I only find out if I happen to run into the issue or a user reports it.

@tstromberg - we can probably close this Issue for now - I don't think anybody has the time and resource to do the integration at present.

@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

10 participants