Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add disks to the minikube VM on Hyperkit? #3883

Closed
leseb opened this issue Mar 15, 2019 · 12 comments · Fixed by #11483
Closed

Ability to add disks to the minikube VM on Hyperkit? #3883

leseb opened this issue Mar 15, 2019 · 12 comments · Fixed by #11483
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. r/2019q2 Issue was last reviewed 2019q2

Comments

@leseb
Copy link

leseb commented Mar 15, 2019

While adding extra disks with the kvm2 driver is easy, I couldn't find anything to add disks on hyperkit. Anyone already doing this perhaps?

Thanks!

@tstromberg
Copy link
Contributor

minikube mount might help here. Is there something else you are trying to do with the disks?

@tstromberg tstromberg added kind/support Categorizes issue or PR as a support question. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. labels Apr 4, 2019
@tstromberg
Copy link
Contributor

Also, do you mind mentioning where you saw something about adding disks with kvm2? It would help me understand a bit better what you are comparing against. Thanks!

@leseb
Copy link
Author

leseb commented Apr 8, 2019

@tstromberg thanks for the reply. I basically trying to add more disks to my VM so they can be consumed by my pods.
For kvm2, you can simply do:

sudo qemu-img create -f raw $IMAGE 30G
sudo virsh attach-disk rook $IMAGE vdb --cache none --persistent

And you will get more disks attached.

Makes sense?

@tstromberg tstromberg added the r/2019q2 Issue was last reviewed 2019q2 label May 23, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2019
@leseb
Copy link
Author

leseb commented Aug 22, 2019

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 22, 2019
@tstromberg
Copy link
Contributor

Evidently hyperkit supports this:

https://github.com/linuxkit/linuxkit/blob/master/docs/platform-hyperkit.md#disks

It might be nice to add something to minikube to pass this kind of thing in.

@tstromberg tstromberg added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/support Categorizes issue or PR as a support question. labels Sep 20, 2019
@sharifelgamal sharifelgamal added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. labels Dec 16, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 16, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 15, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BlaineEXE
Copy link
Contributor

I plan to start some work to try to add functionality into minikube to allow creating extra disks. I anticipate that I will only have the ability to do so for some backends, notably with hyperkit and vbox as I am on Mac. Using the docker machine backend likely won't be able to support this option at all. Is this okay? Are there examples of features that aren't supported by all backends I might use as reference?

I wonder if an alternate option might be to implement it as an addon. Does anyone have any suggestions?

/reopen
/remove-lifecycle rotten

@k8s-ci-robot
Copy link
Contributor

@BlaineEXE: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

I plan to start some work to try to add functionality into minikube to allow creating extra disks. I anticipate that I will only have the ability to do so for some backends, notably with hyperkit and vbox as I am on Mac. Using the docker machine backend likely won't be able to support this option at all. Is this okay? Are there examples of features that aren't supported by all backends I might use as reference?

I wonder if an alternate option might be to implement it as an addon. Does anyone have any suggestions?

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. r/2019q2 Issue was last reviewed 2019q2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants