-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minikube deletes custom network passed in via --kvm-network #3581
Comments
I killed half of day with this situation. |
It seems reasonable that if you pass in --kvm-network=minikube-net - that it should not remove the network. I'd be happy to help review any PR which addresses this. Help wanted! |
Yes, it should not remove the network but it removes :( |
Minikube will create the private network (if it doesn't exist), so seems reasonable it should destroy it. But when you pass in a custom network, it would probably be a good idea to disable this feature... Maybe add a boolean to signal if we created it ? And then skipping over destroying it, if we didn't ? |
Yes, you can add boolean to signal who creates the network. But I think the default behavior must be NOT to delete the custom network. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Hey, took some time to look into this issue. One thing I noticed is that minikube already doesn't delete the network passed with the option As @afbjorklund commented it does delete the Private Network, which isn't the same thing as the option What I think happened in this case it that the network @malcolm061990 created actually had the same name (look on the XML he posted -> |
Thanks! |
BUG REPORT
Minikube version: 0.33.1
What happened:
Hangs at Starting cluster components...
What you expected to happen:
Starting cluster without hangs and errors
How to reproduce it (as minimally and precisely as possible):
Output of
minikube logs
(if applicable):I give only small part of the log because the log is huge
Anything else do we need to know:
Some days ago I could start minikube without problems using 0.27.0 version. I wanted to upgrade it. After upgrade to 0.33.1 this error appeared. Returning to 0.27.0 caused the error too.
I delete the minikube cluster using this:
minikube stop && minikube delete && rm -rf ~/.minikube
The network "minikube-net" was created earlier by
virsh net-create ./minikube/minikube-kvm-network.xml
The content of minikube-kvm-network.xml:
The text was updated successfully, but these errors were encountered: