-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable KVM nesting #2553
Comments
Relevant for kubevirt/kubevirt#736 |
@zakame but we could enable netsing (using the minikube/pkg/drivers/kvm/domain.go Line 30 in 9fe9154
|
@fabiand yep, tag needs to be added in here lik in https://github.com/dhiltgen/docker-machine-kvm/blob/master/kvm.go#L40 |
Before this patch the virtual CPU was the stock qemu CPU, in the sense that the virtual CPU features were set according to the default qemu CPU. With this change the CPU features of the host will be copied at start to the domain definition. This includes features like svm and vmx, which in turn allow to run nested virtualization if the host is configured accordingly i.e. `kvm_intel nested=y` in `/etc/modprobe.d/kvm.conf`. Resolves #kubernetes#2553 Signed-off-by: Fabian Deutsch <[email protected]>
@zakame that patch is adding it unconditionally - this should be safe, but for more compatibility we could make it configurable. |
@fabiand yep, saw your pull too. Definitely something that can be configurable (e.g an |
I've settled with |
Yes that seems nicer and shorter too. Would that take an option (like e.g. |
Exactly. Or Only thing is that oyu need more "domain" knowledge in order to understand what to choose. |
I'm actually still struggling a bit to complete my testing, so stay tuned for some news. |
Before this patch the virtual CPU was the stock qemu CPU, in the sense that the virtual CPU features were set according to the default qemu CPU. With this change the CPU features of the host will be copied at start to the domain definition. This includes features like svm and vmx, which in turn allow to run nested virtualization if the host is configured accordingly i.e. `kvm_intel nested=y` in `/etc/modprobe.d/kvm.conf`. To turn on nesting, a user has to specify `--kvm-cpu-model host-model` when creating the VM. Resolves kubernetes#2553 Signed-off-by: Fabian Deutsch <[email protected]>
The associated PR #2555 will enable nesting, reviews are highly appreciated. |
With passthrough mode we can enable KVM nesting for guests. Fixes kubernetes#2553 Signed-off-by: Fabian Deutsch <[email protected]>
Before this patch the virtual CPU was the stock qemu CPU, in the sense that the virtual CPU features were set according to the default qemu CPU. With this change the CPU features of the host will be copied at start to the domain definition. This includes features like svm and vmx, which in turn allow to run nested virtualization if the host is configured accordingly i.e. `kvm_intel nested=y` in `/etc/modprobe.d/kvm.conf`. To turn on nesting, a user has to specify `--kvm-cpu-model host-model` when creating the VM. Resolves #2553 Signed-off-by: Fabian Deutsch <[email protected]>
With passthrough mode we can enable KVM nesting for guests. Fixes #2553 Signed-off-by: Fabian Deutsch <[email protected]>
Is this a BUG REPORT or FEATURE REQUEST? (choose one): Unsure
Please provide the following details:
Environment: Fedora 26
Minikube version: v0.25.0
What happened: need /dev/kvm inside minikube
What you expected to happen: /dev/kvm is not inside
How to reproduce it (as minimally and precisely as possible): launch minikube look for /dev/kvm (have netsing on the host enabled
Output of
minikube logs
(if applicable):Anything else do we need to know: According to docker-machine-kvm#36 nesting should be at least supported by docker machine.
The text was updated successfully, but these errors were encountered: