Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker version in minikube iso - possible? #1518

Closed
harmon25 opened this issue May 21, 2017 · 9 comments · Fixed by #1542
Closed

Update docker version in minikube iso - possible? #1518

harmon25 opened this issue May 21, 2017 · 9 comments · Fixed by #1542
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@harmon25
Copy link

Is this a BUG REPORT or FEATURE REQUEST?:
FEATURE REQUEST

Minikube version :
v0.19.0

Environment: linux

  • OS : debian jessie
  • VM Driver : virtualbox
  • ISO version : minikube-v0.18.0.iso
  • Install tools: debian installer
  • Others: N/A

What happened:
Am using the new multistage build in docker but this does not work on the minikube iso as it is running docker v1.11.1.

It is in the edge docker release so not expecting this to be implemented in a minikube release anytime soon, but would it be possible to upgrade docker in the minikube-iso to ^17.05?

Have newer versions of docker been tested?
Worry that would be quite the jump...

@dlorenc
Copy link
Contributor

dlorenc commented May 21, 2017

We're due for an update, but we probably can't go all the way to 17.05. We match what upstream kubernetes currently tests with, which will be lagging behind docker for a few releases.

@aaron-prindle aaron-prindle added the kind/feature Categorizes issue or PR as related to a new feature. label May 26, 2017
bryanlarsen added a commit to bryanlarsen/minikube that referenced this issue May 31, 2017
This is an attempt to address kubernetes#1518.   It does actually fix kubernetes#1518, but breaks much of Kubernetes.   :)   Don't merge this, I'm just creating a PR that people can play with if they're interested in taking it further.
@imranity
Copy link

imranity commented Jun 9, 2017

hello, is there any update to this?

@kilianc
Copy link

kilianc commented Jul 7, 2017

It would be nice to have at least >= 1.13.0 so we can use cache_from in docker compose files.

@kilianc
Copy link

kilianc commented Jul 17, 2017

Is there a way to just apt-get docker and update it at our own risk?

@kilianc
Copy link

kilianc commented Jul 28, 2017

see #1542 (comment)

If you are stuck with this, you can preview the custom ISO with:

$ gsutil cp gs://minikube-builds/1542/minikube-darwin-amd64 ~/.bin/minikube
$ minikube start --iso-url=https://storage.googleapis.com/minikube-builds/1542/minikube-testing.iso

Works perfectly for me! 🍻

@Vrtak-CZ
Copy link

Just FYI:

Kubernetes 1.8 supports docker version 1.11.x, 1.12.x and 1.13.x

btw Docker 17.03 (is actually 1.13.x) has been validated for K8s 1.8 too.

@Place1
Copy link

Place1 commented Oct 7, 2017

I'm keen to try multi-stage builds so having docker 17.05+ would be nice :D

@medyagh
Copy link
Member

medyagh commented Oct 13, 2017

We in github.com/k8guard need multi-stage builds, is there any way to update the minikube's docker version manually?

@yairmark
Copy link

As of the 26th of October 2017 the newest version of the Minikube iso has docker 17.05-ce https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md#version-0230---10262017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants