Skip to content

Commit

Permalink
Still support building default in docker
Browse files Browse the repository at this point in the history
Since the docker image is always running Linux amd64, we need to
pass the actual local target to build (cross-compile) minikube for.
  • Loading branch information
afbjorklund committed Nov 2, 2019
1 parent ad22190 commit e5c4720
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,11 @@ endif


out/minikube$(IS_EXE): $(SOURCE_GENERATED) $(SOURCE_FILES) go.mod
ifeq ($(MINIKUBE_BUILD_IN_DOCKER),y)
$(call DOCKER,$(BUILD_IMAGE),GOOS=$(GOOS) GOARCH=$(GOARCH) /usr/bin/make $@)
else
go build -tags "$(MINIKUBE_BUILD_TAGS)" -ldflags="$(MINIKUBE_LDFLAGS)" -o $@ k8s.io/minikube/cmd/minikube
endif

out/minikube-windows-amd64.exe: out/minikube-windows-amd64
cp $< $@
Expand Down

0 comments on commit e5c4720

Please sign in to comment.