Merge pull request #4431 from Pradip-Khakurel/issue-#4161-WantShowDri…

…verDeprecationNotification-setting fix ShowDriverDeprecationNotification config setting
kubernetes · Jun 7, 2019 · dfd9b6b · dfd9b6b
2 parents 80e200e + bb78d3e
commit dfd9b6b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/cmd/minikube/cmd/config/config.go b/cmd/minikube/cmd/config/config.go
@@ -131,6 +131,10 @@ var settings = []Setting{
 		name: Bootstrapper,
 		set:  SetString, //TODO(r2d4): more validation here?
 	},
+	{
+		name: config.ShowDriverDeprecationNotification,
+		set:  SetBool,
+	},
 	{
 		name: config.ShowBootstrapperDeprecationNotification,
 		set:  SetBool,

diff --git a/pkg/minikube/cluster/cluster.go b/pkg/minikube/cluster/cluster.go
@@ -325,21 +325,21 @@ func preCreateHost(config *cfg.MachineConfig) {
 			console.Warning(`The kvm driver is deprecated and support for it will be removed in a future release.
 				Please consider switching to the kvm2 driver, which is intended to replace the kvm driver.
 				See https://github.com/kubernetes/minikube/blob/master/docs/drivers.md#kvm2-driver for more information.
-				To disable this message, run [minikube config set WantShowDriverDeprecationNotification false]`)
+				To disable this message, run [minikube config set ShowDriverDeprecationNotification false]`)
 		}
 	case "xhyve":
 		if viper.GetBool(cfg.ShowDriverDeprecationNotification) {
 			console.Warning(`The xhyve driver is deprecated and support for it will be removed in a future release.
 Please consider switching to the hyperkit driver, which is intended to replace the xhyve driver.
 See https://github.com/kubernetes/minikube/blob/master/docs/drivers.md#hyperkit-driver for more information.
-To disable this message, run [minikube config set WantShowDriverDeprecationNotification false]`)
+To disable this message, run [minikube config set ShowDriverDeprecationNotification false]`)
 		}
 	case "vmwarefusion":
 		if viper.GetBool(cfg.ShowDriverDeprecationNotification) {
 			console.Warning(`The vmwarefusion driver is deprecated and support for it will be removed in a future release.
 				Please consider switching to the new vmware unified driver, which is intended to replace the vmwarefusion driver.
 				See https://github.com/kubernetes/minikube/blob/master/docs/drivers.md#vmware-unified-driver for more information.
-				To disable this message, run [minikube config set WantShowDriverDeprecationNotification false]`)
+				To disable this message, run [minikube config set ShowDriverDeprecationNotification false]`)
 		}
 	}
 }