Skip to content

Commit

Permalink
Add unit testcase for addon file patterns
Browse files Browse the repository at this point in the history
afero introduced for mocking a filesystem.
  • Loading branch information
laozc committed Feb 10, 2019
1 parent 0c1d3f2 commit 979d177
Showing 1 changed file with 156 additions and 0 deletions.
156 changes: 156 additions & 0 deletions pkg/minikube/assets/addons_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,156 @@
/*
Copyright 2016 The Kubernetes Authors All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package assets

import (
"io/ioutil"
"os"
"path/filepath"
"testing"

"k8s.io/minikube/pkg/minikube/constants"
)

func setupTestDir() (string, error) {
path, err := ioutil.TempDir("", "minipath")
if err != nil {
return "", err
}

os.Setenv(constants.MinikubeHome, path)
return path, err
}

func TestAddMinikubeDirAssets(t *testing.T) {

tests := []struct {
description string
baseDir string
files []struct {
relativePath string
expectedPath string
}
vmPath string
expectedCfg string
}{
{
description: "relative path assets",
baseDir: "/files",
files: []struct {
relativePath string
expectedPath string
}{
{
relativePath: "/dir1/file1.txt",
expectedPath: constants.AddonsPath,
},
{
relativePath: "/dir1/file2.txt",
expectedPath: constants.AddonsPath,
},
{
relativePath: "/dir2/file1.txt",
expectedPath: constants.AddonsPath,
},
},
vmPath: constants.AddonsPath,
},
{
description: "absolute path assets",
baseDir: "/files",
files: []struct {
relativePath string
expectedPath string
}{
{
relativePath: "/dir1/file1.txt",
expectedPath: "/dir1",
},
{
relativePath: "/dir1/file2.txt",
expectedPath: "/dir1",
},
{
relativePath: "/dir2/file1.txt",
expectedPath: "/dir2",
},
},
vmPath: "",
},
}
for _, test := range tests {
t.Run(test.description, func(t *testing.T) {
testDir, err := setupTestDir()
if err != nil {
t.Errorf("got unexpected error creating test dir: %v", err)
return
}

defer func() {
err := os.RemoveAll(testDir)
if err != nil {
t.Errorf("got unexpected error removing test dir: %v", err)
}
}()

testFileBaseDir := filepath.Join(testDir, test.baseDir)
assetNames := make([]string, 0)
for _, fileDef := range test.files {
err := func() error {
path := filepath.Join(testFileBaseDir, fileDef.relativePath)
assetNames = append(assetNames, path)
err := os.MkdirAll(filepath.Dir(path), 0755)
if err != nil {
return err
}

file, err := os.Create(path)
if err != nil {
return err
}

defer file.Close()

_, err = file.WriteString("test")
return err
}()
if err != nil {
t.Errorf("unable to create file on fs: %v", err)
return
}
}

var actualFiles []CopyableFile
err = addMinikubeDirToAssets(testFileBaseDir, test.vmPath, &actualFiles)
if err != nil {
t.Errorf("got unexpected error adding minikube dir assets: %v", err)
return
}
for idx, actualFile := range actualFiles {
if actualFile.GetAssetName() != assetNames[idx] {
t.Errorf("actual file assets does not match expected. actual:\n%s\nexpected:\n%s", actualFile.GetAssetName(), assetNames[idx])
return
}
if actualFile.GetTargetDir() != test.files[idx].expectedPath {
t.Errorf("actual file target dir does not match expected. actual:\n%s\nexpected:\n%s", actualFile.GetTargetDir(), test.files[idx].expectedPath)
return
}
}
})
}

}

0 comments on commit 979d177

Please sign in to comment.