Skip to content

Commit

Permalink
Fix registry addon ReplicationController template
Browse files Browse the repository at this point in the history 
Running the `minikube addons enable registry` yields `registry was successfully enabled` but no `registry` Pod ends up being run.

I've narrowed it down to this `env` entry not being quoted.

Logs from `kube-addon-manager-minikube` Pod show this error:

```
Error from server (BadRequest): error when creating "/etc/kubernetes/addons/registry-rc.yaml": ReplicationController in version "v1" cannot be handled as a ReplicationController: v1.ReplicationController.Spec: v1.ReplicationControllerSpec.Template: v1.PodTemplateSpec.Spec: v1.PodSpec.Containers: []v1.Container: v1.Container.Env: []v1.EnvVar: v1.EnvVar.Value: ReadString: expects " or n, but found t, error found in #10 byte of ...|,"value":true}],"ima|..., bigger context ...|"name":"REGISTRY_STORAGE_DELETE_ENABLED","value":true}],"image":"registry.hub.docker.com/library/reg|...
```
  • Loading branch information
@zregvart
zregvart authored May 7, 2019
1 parent 2cd5336 commit 40da502
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion deploy/addons/registry/registry-rc.yaml.tmpl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ spec:
protocol: TCP
env:
- name: REGISTRY_STORAGE_DELETE_ENABLED
value: true
value: "true"

3 comments on commit 40da502

@johnkattenhorn
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to give this a try @zregvart ; can I copy this file onto my existing environment and take advantage of the fix ?

@zregvart
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been merged and released, why not use the released version?

@johnkattenhorn
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok - I did'nt release it was out into a release already - kubectl get pods --all-namespaces confirms that the registry is up. Thanks @zregvart

Please sign in to comment.