Skip to content

Commit

Permalink
Apply code review changes
Browse files Browse the repository at this point in the history
Rename "cmd*" var to "bin*" in the parallels-specific block
  • Loading branch information
legal90 committed May 23, 2020
1 parent c22a92f commit 2b8bac6
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions pkg/minikube/cluster/ip.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,14 @@ func HostIP(host *host.Host) (net.IP, error) {
ip := re.FindStringSubmatch(string(ipList))[1]
return net.ParseIP(ip), nil
case driver.Parallels:
cmd := "prlsrvctl"
var cmdPath string
if fullPath, err := exec.LookPath(cmd); err != nil {
cmdPath = fullPath
bin := "prlsrvctl"
var binPath string
if fullPath, err := exec.LookPath(bin); err != nil {
binPath = fullPath
} else {
cmdPath = cmd
binPath = bin
}
out, err := exec.Command(cmdPath, "net", "info", "Shared").Output()
out, err := exec.Command(binPath, "net", "info", "Shared").Output()
if err != nil {
return []byte{}, errors.Wrap(err, "Error reading the info of Parallels Shared network interface")
}
Expand Down

0 comments on commit 2b8bac6

Please sign in to comment.