Skip to content

Commit

Permalink
Fix KVM naming
Browse files Browse the repository at this point in the history
  • Loading branch information
josedonizetti committed Jun 25, 2019
1 parent 8f0ee4c commit 107a7bc
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions cmd/minikube/cmd/start.go
Original file line number Diff line number Diff line change
Expand Up @@ -497,8 +497,8 @@ func generateConfig(cmd *cobra.Command, k8sVersion string) (cfg.Config, error) {
RegistryMirror: registryMirror,
HostOnlyCIDR: viper.GetString(hostOnlyCIDR),
HypervVirtualSwitch: viper.GetString(hypervVirtualSwitch),
KvmNetwork: viper.GetString(kvmNetwork),
KvmQemuURI: viper.GetString(kvmQemuURI),
KVMNetwork: viper.GetString(kvmNetwork),
KVMQemuURI: viper.GetString(kvmQemuURI),
Downloader: pkgutil.DefaultDownloader{},
DisableDriverMounts: viper.GetBool(disableDriverMounts),
UUID: viper.GetString(uuid),
Expand Down
4 changes: 2 additions & 2 deletions pkg/minikube/config/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ type MachineConfig struct {
RegistryMirror []string
HostOnlyCIDR string // Only used by the virtualbox driver
HypervVirtualSwitch string
KvmNetwork string // Only used by the KVM driver
KvmQemuURI string // Only used by kvm2
KVMNetwork string // Only used by the KVM driver
KVMQemuURI string // Only used by kvm2
Downloader util.ISODownloader `json:"-"`
DockerOpt []string // Each entry is formatted as KEY=VALUE.
DisableDriverMounts bool // Only used by virtualbox and xhyve
Expand Down
2 changes: 1 addition & 1 deletion pkg/minikube/drivers/kvm/driver.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ func createKVMHost(config cfg.MachineConfig) interface{} {
},
Memory: config.Memory,
CPU: config.CPUs,
Network: config.KvmNetwork,
Network: config.KVMNetwork,
PrivateNetwork: "docker-machines",
Boot2DockerURL: config.Downloader.GetISOFileURI(config.MinikubeISO),
DiskSize: config.DiskSize,
Expand Down
4 changes: 2 additions & 2 deletions pkg/minikube/drivers/kvm2/driver.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,14 @@ func createKVM2Host(config cfg.MachineConfig) interface{} {
},
Memory: config.Memory,
CPU: config.CPUs,
Network: config.KvmNetwork,
Network: config.KVMNetwork,
PrivateNetwork: "minikube-net",
Boot2DockerURL: config.Downloader.GetISOFileURI(config.MinikubeISO),
DiskSize: config.DiskSize,
DiskPath: filepath.Join(constants.GetMinipath(), "machines", cfg.GetMachineName(), fmt.Sprintf("%s.rawdisk", cfg.GetMachineName())),
ISO: filepath.Join(constants.GetMinipath(), "machines", cfg.GetMachineName(), "boot2docker.iso"),
GPU: config.GPU,
Hidden: config.Hidden,
ConnectionURI: config.KvmQemuURI,
ConnectionURI: config.KVMQemuURI,
}
}
2 changes: 1 addition & 1 deletion test/integration/start_stop_delete_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func TestStartStop(t *testing.T) {
// default is the network created by libvirt, if we change the name minikube won't boot
// because the given network doesn't exist
"--kvm-network=default",
"--kvm-qemu-uri=qemu:///sytem",
"--kvm-qemu-uri=qemu:///system",
}},
{"feature_gates_newest_cni", []string{
"--feature-gates",
Expand Down

0 comments on commit 107a7bc

Please sign in to comment.