Skip to content

Comments

Skip PD tests on 1 node cluster#98187

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
jsafrane:skip-2node
Jan 27, 2021
Merged

Skip PD tests on 1 node cluster#98187
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
jsafrane:skip-2node

Conversation

@jsafrane
Copy link
Member

@jsafrane jsafrane commented Jan 19, 2021

/kind cleanup
/kind failing-test

What this PR does / why we need it:
The PD tests should skip themselves if they observe only 1 node is schedulable. The tests already check for SkipUnlessNodeCountIsAtLeast, but it checks for all nodes, not the schedulable ones.

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@jsafrane
Skip PD tests on 1 node cluster
b356030 
The PD tests should skip themselves if they observe only 1 node is
schedulable.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 19, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 19, 2021

@jsafrane: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 19, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2021
@jsafrane
Copy link
Member Author

jsafrane commented Jan 27, 2021

/retest

bertinatto
bertinatto reviewed Jan 27, 2021
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Helps running tests in smaller clusters.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6a4a0cd into kubernetes:master Jan 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 27, 2021
@openshift-ci-robot openshift-ci-robot mentioned this pull request Feb 2, 2021
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saad-ali saad-ali Awaiting requested review from saad-ali

@xing-yang xing-yang Awaiting requested review from xing-yang

1 more reviewer

@bertinatto bertinatto bertinatto left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@bertinatto bertinatto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.21

Development

Successfully merging this pull request may close these issues.

3 participants

@jsafrane @k8s-ci-robot @bertinatto