Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating EndpointSlice controller to wait for all caches to be synced #94086

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

robscott
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
Previously the EndpointSlice controller was not waiting for EndpointSlices or Nodes to be synced.

Special notes for your reviewer:
As identified by @liggitt in #93496 (comment)

Does this PR introduce a user-facing change?:

The EndpointSlice controller now waits for EndpointSlice and Node caches to be synced before starting.

/sig network
/priority critical-urgent
/cc @freehan @liggitt

Previously the EndpointSlice controller was not waiting for
EndpointSlices or Nodes to be synced.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/network Categorizes an issue or PR as relevant to SIG Network. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Aug 18, 2020
@liggitt
Copy link
Member

liggitt commented Aug 18, 2020

thanks, did you sweep all the controllers involved in endpointslices to make sure they waited for caches correctly?

@liggitt
Copy link
Member

liggitt commented Aug 18, 2020

/lgtm
/approve
/milestone v1.19

required to avoid endpointslice churn on startup. this should be picked to all releases where the controller was enabled

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 18, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit a690a36 into kubernetes:master Aug 18, 2020
@robscott
Copy link
Member Author

@liggitt thanks for checking! I did confirm that both Endpoints and EndpointSliceMirroring controllers are waiting for the appropriate caches. For the record, EndpointSliceMirroring waits for endpoints, endpointslices, and services. Endpoints waits for pods, services, and endpoints.

k8s-ci-robot added a commit that referenced this pull request Sep 2, 2020
…86-upstream-release-1.18

Automated cherry pick of #94086: Updating EndpointSlice controller to wait for all caches to
k8s-ci-robot added a commit that referenced this pull request Sep 2, 2020
…86-upstream-release-1.17

Automated cherry pick of #94086: Updating EndpointSlice controller to wait for all caches to
@robscott robscott deleted the endpointslice-sync-fix branch March 11, 2021 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants