Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #86557: If lastTimestamp is not set use firstTimestamp when printing #89999: If firstTimestamp is not set use eventTime when printing #91055

Merged
merged 2 commits into from
Jun 18, 2020
Merged

Automated cherry pick of #86557: If lastTimestamp is not set use firstTimestamp when printing #89999: If firstTimestamp is not set use eventTime when printing #91055

merged 2 commits into from
Jun 18, 2020
+87 −0

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented May 13, 2020 •
edited
Loading

Cherry pick of #86557 #89999 on release-1.17.

#86557: If lastTimestamp is not set use firstTimestamp when printing
#89999: If firstTimestamp is not set use eventTime when printing

For details on the cherry pick process, see the cherry pick requests page.

If firstTimestamp is not set use firstTimestamp or eventTime when printing event

@k8s-ci-robot
Copy link
Contributor

@soltysh: This cherry pick PR is for a release branch and has not yet been approved by the Patch Release Team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, please ping the kubernetes/patch-release-team in a comment, after it has been approved by the relevant OWNERS.
For details on the patch release process and schedule, see the Patch Releases page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone May 13, 2020
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2020
@soltysh soltysh mentioned this pull request May 13, 2020
Merged
@soltysh
Copy link
Contributor Author

soltysh commented May 13, 2020

/sig cli
/priority backlog
/kind bug

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. priority/backlog Higher priority than priority/awaiting-more-evidence. kind/bug Categorizes issue or PR as related to a bug. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 13, 2020
@soltysh
Copy link
Contributor Author

soltysh commented May 13, 2020

@kubernetes/patch-release-team for cherry-pick approval

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 13, 2020
@soltysh
Copy link
Contributor Author

soltysh commented May 13, 2020

/assign @zhouya0

@zhouya0
Copy link
Contributor

zhouya0 commented May 13, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2020
@zhouya0
Copy link
Contributor

zhouya0 commented May 14, 2020

/retest

@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 17, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 17, 2020
@zhouya0
Copy link
Contributor

zhouya0 commented Jun 18, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6c458a5 into kubernetes:release-1.17 Jun 18, 2020
@soltysh soltysh deleted the automated-cherry-pick-of-#86557-#89999-upstream-release-1.17 branch July 9, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@eparis eparis Awaiting requested review from eparis

Assignees

@zhouya0 zhouya0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.
4 participants
@soltysh @k8s-ci-robot @zhouya0 @tpepper