-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix e2e network performance test #90486
Conversation
I've tested it locally, don't know if this is running in some CI
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
/assign @danwinship |
/retest |
@aojea I don't have approver power but will try this out locally and give another review. Can you confirm how you ran this test locally? I'm gonna try a kubetest build against a cloud cluster. |
I test it using kind kubernetes-sigs/kind#1181 (comment) |
It probably runs in one of the periodic jobs, not something you can run from a PR. One way to get around that is to just push a temporary commit changing the tags on the test you want to run so it's no longer skipped in the default runs. But anyway, the fix looks right and you tested it. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind failing-test
What this PR does / why we need it:
The agnhost image has the
agnhost
binary as entrypoint.The networking performance test need to run iperf overriding the entrypoint
Which issue(s) this PR fixes:
Fixes #90450
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: