Skip to content

fix: add azure disk migration support on CSINode #88014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2020
Merged

fix: add azure disk migration support on CSINode #88014

merged 1 commit into from
Feb 12, 2020

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Feb 11, 2020 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: add azure disk migration support for CSINode

Which issue(s) this PR fixes:

Fixes #88015

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: add azure disk migration support for CSINode

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/kind bug
/assign @davidz627
/priority important-soon
/sig cloud-provider
/area provider/azure

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. area/provider/azure Issues or PRs related to azure provider labels Feb 11, 2020
@andyzhangx andyzhangx requested a review from davidz627 February 11, 2020 11:44
@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Feb 11, 2020
@andyzhangx andyzhangx mentioned this pull request Feb 11, 2020
Closed
@andyzhangx andyzhangx changed the title fix: add azure disk migration support for CSINode fix: add azure disk migration support on CSINode Feb 11, 2020
@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gce-csi-serial

feiskyer
feiskyer reviewed Feb 11, 2020
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2020
@davidz627
Copy link
Contributor

/lgtm
/approve
/cc @ddebroy
do you think it would be possible/easy to refactor this so that the logic only exists in our new MigrationManager or whatever it was called :)

@k8s-ci-robot k8s-ci-robot requested a review from ddebroy February 11, 2020 19:10
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, davidz627, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2020
@davidz627
Copy link
Contributor

/retest

1 similar comment
@davidz627
Copy link
Contributor

/retest

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit 92be16c into kubernetes:master Feb 12, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 12, 2020
@andyzhangx andyzhangx mentioned this pull request Feb 12, 2020
Merged
@andyzhangx andyzhangx mentioned this pull request Feb 20, 2020
Merged
k8s-ci-robot added a commit that referenced this pull request Feb 21, 2020
@k8s-ci-robot
Merge pull request #88078 from andyzhangx/automated-cherry-pick-of-#8…
16c07ca 
…8014-upstream-release-1.17

Automated cherry pick of #88014: fix: add azure disk migration support for CSINode
@andyzhangx andyzhangx mentioned this pull request Mar 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@davidz627 davidz627 Awaiting requested review from davidz627

@saad-ali saad-ali Awaiting requested review from saad-ali

@ddebroy ddebroy Awaiting requested review from ddebroy

Assignees

@feiskyer feiskyer

@davidz627 davidz627

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

azure disk migration does not work on CSINode
4 participants
@andyzhangx @davidz627 @k8s-ci-robot @feiskyer