Make elasticsearch discovery supports IPv6 #85543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
/test pull-kubernetes-e2e-kind |
aojea
reviewed
Nov 23, 2019
| @@ -52,7 +53,13 @@ func flattenSubsets(subsets []corev1.EndpointSubset) []string { | |||
| ips := []string{} | |||
| for _, ss := range subsets { | |||
| for _, addr := range ss.Addresses { | |||
| ips = append(ips, fmt.Sprintf(`"%s"`, addr.IP)) | |||
| if ip := net.ParseIP(addr.IP); ip != nil { | |||
There was a problem hiding this comment.
nit, you have a function in k/utils that is doing this
https://github.com/kubernetes/utils/blob/6ca3b61696b65b0e81f1a39b4937fc2d2994ed6a/net/net.go#L121
SataQiu
force-pushed
the
fix-elasticsearch-20191122
branch
from
955a02f
to
bbbf396
Compare
|
/assign @monotek @coffeepac |
|
/assign @dims |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
coffeepac
approved these changes
Dec 1, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: coffeepac, SataQiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Make elasticsearch discovery supports IPv6.
As IPv6 address contains
:(one of the special value), it should be bracketed.Without this PR, it won't resolve the IPv6 address correctly and will fail to start.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: