Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update etcd client to v3.4.3 in k8s v1.17 #83987

Merged
merged 4 commits into from
Oct 25, 2019
Merged

Update etcd client to v3.4.3 in k8s v1.17 #83987

merged 4 commits into from
Oct 25, 2019

Conversation

wenjiaswe
Copy link
Contributor

@wenjiaswe wenjiaswe commented Oct 16, 2019 •
edited
Loading

Replace #83209

What type of PR is this?
/kind feature

What this PR does / why we need it:
Update etcd client to v3.4.3 in k8s 1.17

Which issue(s) this PR fixes:

Fixes ##82641

Does this PR introduce a user-facing change?:

Update etcd client side to v3.4.3
Deprecated prometheus request meta-metrics have been removed (http_request_duration_microseconds, http_request_duration_microseconds_sum, http_request_duration_microseconds_count, http_request_size_bytes, http_request_size_bytes_sum, http_request_size_bytes_count, http_requests_total, http_response_size_bytes, http_response_size_bytes_sum, http_response_size_bytes_count) due to removal from the prometheus client library. Prometheus http request meta-metrics are now generated from [promhttp.InstrumentMetricHandler](https://godoc.org/github.com/prometheus/client_golang/prometheus/promhttp#InstrumentMetricHandler) instead.

/cc @wojtek-t @liggitt @jpbetz

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubeadm area/kubectl area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 16, 2019
@wenjiaswe wenjiaswe force-pushed the etcd_client_3_4_2 branch 4 times, most recently from 436699b to 043e5eb Compare October 16, 2019 09:04
@wenjiaswe
Copy link
Contributor Author

/retest

1 similar comment
@wenjiaswe
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Oct 24, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. labels Oct 24, 2019
@wenjiaswe
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 24, 2019 •
edited
Loading

@wenjiaswe: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-alpha-features b9e922272f627ad29d4565a5eba2e09271db1886 link /test pull-kubernetes-e2e-gce-alpha-features
pull-kubernetes-e2e-gce-csi-serial b9e922272f627ad29d4565a5eba2e09271db1886 link /test pull-kubernetes-e2e-gce-csi-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

logicalhan
logicalhan reviewed Oct 24, 2019
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm from an instrumentation POV

@wenjiaswe
Copy link
Contributor Author

@liggitt All tests passed and @logicalhan lgtmed, PTAL. thanks.

@liggitt
Copy link
Member

liggitt commented Oct 25, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, wenjiaswe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2019
@jingyih jingyih mentioned this pull request Oct 25, 2019
Merged
@wojtek-t
Copy link
Member

@wenjiaswe - I think we can hold cancel now, right? Or maybe we want to wait until Monday to not merge it on Friday?

@wenjiaswe
Copy link
Contributor Author

@wojtek-t I only kept the hold because I thought we need to wait for #83968 to merge? Or is that not necessary?

@brancz
Copy link
Member

brancz commented Oct 25, 2019

Double checking things from instrumentation side as well and this lgtm as well.

@liggitt
Copy link
Member

liggitt commented Oct 25, 2019

we don't need to wait for the 1.16 pick. we got scale results on master already.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2019
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@k8s-ci-robot k8s-ci-robot merged commit 09f453f into kubernetes:master Oct 25, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 25, 2019
@jingyih jingyih mentioned this pull request Mar 16, 2020
Closed
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#83987 from wenjiaswe/etcd_client_3_4_2
bba33b6 
Update etcd client to v3.4.3 in k8s v1.17

Kubernetes-commit: 09f453f
@anton-johansson anton-johansson mentioned this pull request Aug 12, 2020
Closed
@wenjiaswe wenjiaswe deleted the etcd_client_3_4_2 branch September 2, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@logicalhan logicalhan logicalhan left review comments

@alejandrox1 alejandrox1 Awaiting requested review from alejandrox1

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

Assignees

@jpbetz jpbetz

@logicalhan logicalhan

@liggitt liggitt

@brancz brancz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubeadm area/kubectl area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.