Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disable outbound snat when Azure standard load balancer is used #75282

Merged
merged 1 commit into from
Mar 13, 2019

Conversation

feiskyer
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind bug

What this PR does / why we need it:

Azure outbound rules are not taking effect when used together with standard load balancer .

This PR adds a new configuration for disabling SNAT for load balancer rules, so that outbound rules would be used as the egress IPs.

In such case, disableOutboundSNAT should be set to true and loadBalancerSku should be set to standard.

Which issue(s) this PR fixes:

Fixes #75281

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Allow disable outbound SNAT when Azure standard load balancer is used together with outbound rules. 

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 12, 2019
@feiskyer
Copy link
Member Author

Added to v1.14 since it is a critical bug fix.

/kind bug
/sig azure
/milestone v1.14
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Mar 12, 2019
@k8s-ci-robot k8s-ci-robot added sig/azure priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 12, 2019
@feiskyer
Copy link
Member Author

/assign @andyzhangx @khenidak

@feiskyer
Copy link
Member Author

/test pull-kubernetes-e2e-aks-engine-azure

@k8s-ci-robot k8s-ci-robot added the sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. label Mar 12, 2019
@feiskyer
Copy link
Member Author

/test pull-kubernetes-e2e-aks-engine-azure

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2019
@feiskyer
Copy link
Member Author

/retest

1 similar comment
@feiskyer
Copy link
Member Author

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@feiskyer
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 815086f into kubernetes:master Mar 13, 2019
@feiskyer feiskyer deleted the disable-outboud-snat branch March 13, 2019 12:06
k8s-ci-robot added a commit that referenced this pull request Mar 14, 2019
…82-upstream-release-1.12

Automated cherry pick of #75282: Allow disable outbound snat when Azure standard load balancer
k8s-ci-robot added a commit that referenced this pull request Mar 19, 2019
…82-upstream-release-1.13

Automated cherry pick of #75282: Allow disable outbound snat when Azure standard load balancer
k8s-ci-robot added a commit that referenced this pull request Mar 21, 2019
…82-upstream-release-1.11

Automated cherry pick of #75282: Allow disable outbound snat when Azure standard load balancer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure outbound rules is not taking effect when using together with standard loadbalancer
5 participants