Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openapi: remove postprocessing for old paths, deprecated in 1.9 #74596

Merged
merged 2 commits into from
Feb 28, 2019
Merged

openapi: remove postprocessing for old paths, deprecated in 1.9 #74596

merged 2 commits into from
Feb 28, 2019

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Feb 26, 2019 •
edited
Loading 

The kube-apiserver OpenAPI definitions with the prefix "io.k8s.kubernetes.pkg" (deprecated since 1.9) have been removed.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 26, 2019
@sttts
Copy link
Contributor Author

sttts commented Feb 26, 2019

/assign @mbohlool

@sttts sttts added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 26, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 26, 2019
@sttts sttts added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 26, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Feb 26, 2019
@sttts sttts added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Feb 26, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 26, 2019
@sttts sttts added this to the v1.14 milestone Feb 26, 2019
@mbohlool
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2019
@sttts
Copy link
Contributor Author

sttts commented Feb 28, 2019

/assign @liggitt

This is formally an API change. Please take a look.

@liggitt
Copy link
Member

liggitt commented Feb 28, 2019

/approve

suggest being specific in the release note about the old definition prefix that was removed

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2019
@sttts
Copy link
Contributor Author

sttts commented Feb 28, 2019

Made the release-notes more specific.

@k8s-ci-robot k8s-ci-robot merged commit e476ab6 into kubernetes:master Feb 28, 2019
@liggitt liggitt mentioned this pull request Jun 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaoShuFeng CaoShuFeng Awaiting requested review from CaoShuFeng

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@liggitt liggitt

@mbohlool mbohlool

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.
4 participants
@sttts @mbohlool @liggitt @k8s-ci-robot