Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix negative slice index error in keymutex in 1.13 #74386

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

danielqsj
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

This issue #73858 report that the generated index for slice in keymutex maybe negative in some platform (like arm).

This PR aims to fix this issue.

Which issue(s) this PR fixes:

Fixes #73858

Special notes for your reviewer:

Already fixed it in master branch by kubernetes/utils#84.
But in before 1.14, keymutex code is in k/k, so I submit this PR to fix it in 1.13, and then will cherrypick to 1.12.

Does this PR introduce a user-facing change?:

Fix keymutex issues which may crash in some platforms.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 22, 2019
@danielqsj
Copy link
Contributor Author

/assign @aleksandra-malinowska

@danielqsj danielqsj changed the title fix negative slice index error in keymutex fix negative slice index error in keymutex in 1.13 Feb 22, 2019
@danielqsj
Copy link
Contributor Author

/cc @apelisse

@tpepper
Copy link
Member

tpepper commented Feb 22, 2019

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 22, 2019
@aleksandra-malinowska aleksandra-malinowska added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Feb 26, 2019
@aleksandra-malinowska
Copy link
Contributor

Please get approve and LGTM as for any other PR.

@apelisse
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2019
@danielqsj
Copy link
Contributor Author

/assign @thockin

@thockin
Copy link
Member

thockin commented Feb 27, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, danielqsj, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit a3bf928 into kubernetes:release-1.13 Feb 27, 2019
k8s-ci-robot added a commit that referenced this pull request Feb 28, 2019
…386-upstream-release-1.12

Automated cherry pick of #74386: fix negative slice index error in keymutex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants