Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix device mountable volume names in DSW #71509

Merged
merged 3 commits into from
Dec 19, 2018
Merged

Fix device mountable volume names in DSW #71509

merged 3 commits into from
Dec 19, 2018

Conversation

cofyc
Copy link
Member

@cofyc cofyc commented Nov 28, 2018 •
edited
Loading

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

This helps to serialize actions on local volume global path. This prevents races on same local volume, see #71438 (comment).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Partially address #71438

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix device mountable volume names in DSW to prevent races in device mountable plugin, e.g. local.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 28, 2018
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 28, 2018
@cofyc cofyc mentioned this pull request Nov 28, 2018
Closed
@cofyc
Copy link
Member Author

cofyc commented Nov 28, 2018

/sig storage

@cofyc
Copy link
Member Author

cofyc commented Nov 28, 2018

/assign @msau42

@cofyc cofyc force-pushed the fix71438 branch 4 times, most recently from 5155de6 to 8acb32e Compare November 28, 2018 13:11
@cofyc
Copy link
Member Author

cofyc commented Nov 29, 2018

/retest

resouer
resouer reviewed Nov 29, 2018
View reviewed changes
pkg/volume/local/local.go Outdated
@@ -16,6 +16,11 @@ limitations under the License.

package local

//
Copy link
Contributor

@resouer resouer Nov 29, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest move this comment to where the lock is used below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion! Done.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 29, 2018
resouer
resouer reviewed Nov 29, 2018
View reviewed changes
Copy link
Contributor

@resouer resouer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over looks good :-)

@msau42
Copy link
Member

msau42 commented Nov 29, 2018

UnmountDevice is not supposed to be called until all references are gone. And should be serialized with MountVolume. I think we should investigate potential issues with operation executor because it's expected to be able to handle this race.

@cofyc
Copy link
Member Author

cofyc commented Nov 30, 2018

Oh, if it's expected to handle this race, I am going to check it.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/kubelet and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 30, 2018
@cofyc
Copy link
Member Author

cofyc commented Dec 12, 2018

/retest

@jingxu97
Copy link
Contributor

/test pull-kubernetes-local-e2e-containerized

@jingxu97
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2018
@cofyc
Copy link
Member Author

cofyc commented Dec 13, 2018

/test pull-kubernetes-local-e2e-containerized

saad-ali
saad-ali approved these changes Dec 18, 2018
View reviewed changes
Copy link
Member

@saad-ali saad-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cofyc, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2018
@cofyc
Copy link
Member Author

cofyc commented Dec 18, 2018

/test pull-kubernetes-godeps

@cofyc
Copy link
Member Author

cofyc commented Dec 18, 2018

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 18, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

7 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@cofyc
Copy link
Member Author

cofyc commented Dec 19, 2018

/test pull-kubernetes-kubemark-e2e-gce-big

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit cd02e75 into kubernetes:master Dec 19, 2018
This was referenced Dec 21, 2018
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Jan 8, 2019
@k8s-ci-robot
Merge pull request #72266 from cofyc/automated-cherry-pick-of-#71509-…
5366776 
…upstream-release-1.13

Automated cherry pick of #71509: Fix device mountable volume names in DSW
k8s-ci-robot added a commit that referenced this pull request Jan 8, 2019
@k8s-ci-robot
Merge pull request #72265 from cofyc/automated-cherry-pick-of-#71509-…
188084d 
…upstream-release-1.12

Automated cherry pick of #71509: Fix device mountable volume names in DSW
@cofyc cofyc deleted the fix71438 branch May 4, 2019 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@resouer resouer resouer left review comments

@saad-ali saad-ali saad-ali approved these changes

@jsafrane jsafrane Awaiting requested review from jsafrane

@rootfs rootfs Awaiting requested review from rootfs

Assignees

@saad-ali saad-ali

@jingxu97 jingxu97

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cofyc @msau42 @jingxu97 @k8s-ci-robot @fejta-bot @resouer @saad-ali