Skip to content

e2e: remove "nodes" permission from driver-registrar RBAC#70582

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
pohly:csi-driver-registrar-rbac
Nov 3, 2018
Merged

e2e: remove "nodes" permission from driver-registrar RBAC#70582
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
pohly:csi-driver-registrar-rbac

Conversation

@pohly
Copy link
Copy Markdown
Contributor

@pohly pohly commented Nov 2, 2018

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

In the review of
kubernetes-retired/driver-registrar#69 it was
pointed out that the "nodes" permissions are not longer needed.

Special notes for your reviewer:

The same change will also be merged via kubernetes-retired/driver-registrar#69 into the upstream driver-registrar repo.

Does this PR introduce a user-facing change?:

NONE

In the review of
kubernetes-retired/driver-registrar#69 it was
pointed out that the "nodes" permissions are not longer needed.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 2, 2018
@pohly
Copy link
Copy Markdown
Contributor Author

pohly commented Nov 2, 2018

/sig storage
/cc @msau42

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Nov 2, 2018
@k8s-ci-robot k8s-ci-robot requested a review from msau42 November 2, 2018 11:32
@msau42
Copy link
Copy Markdown
Member

msau42 commented Nov 2, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2018
@saad-ali
Copy link
Copy Markdown
Member

saad-ali commented Nov 2, 2018

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2018
@k8s-ci-robot k8s-ci-robot merged commit 408973d into kubernetes:master Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants