Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix openstack provider to handle only Cinder volumes #70459

Merged
merged 1 commit into from
Oct 31, 2018
Merged

fix openstack provider to handle only Cinder volumes #70459

merged 1 commit into from
Oct 31, 2018

Conversation

mvladev
Copy link

@mvladev mvladev commented Oct 31, 2018 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
When the cloud-controller-manager is running with PV label initializing controller and NFS volume is created, it causes nil pointer dereference error.

Which issue(s) this PR fixes:
openstack variant of #68996

Special notes for your reviewer:
This the OpenStack variant of #70432 .

Does this PR introduce a user-facing change?:

Fix cloud-controller-manager crash when using OpenStack provider and PersistentVolume initializing controller

/sig cloud-provider
/sig openstack

fix openstack provider to handle only Cinder volumes
3b0ddbf 
When the cloud-controller-manager is running with PV label initializing controller
and NFS volume is created, it causes nill reference error.

related to kubernetes#68996
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. area/provider/openstack Issues or PRs related to openstack provider needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 31, 2018
@mvladev
Copy link
Author

mvladev commented Oct 31, 2018

/assign @NickrenREN

@idealhack
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 31, 2018
@NickrenREN
Copy link
Contributor

LGTM, thanks @mvladev

/approve

BTW: could you add UTs for openstack too just like you did for aws and gce ?
also can you send you PR here https://github.com/kubernetes/cloud-provider-openstack too ?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mvladev, NickrenREN

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2018
@adisky
Copy link
Contributor

adisky commented Oct 31, 2018

lgtm

@mvladev
Copy link
Author

mvladev commented Oct 31, 2018

@NickrenREN

BTW: could you add UTs for openstack too just like you did for aws and gce ?

I've been looking at this, but it seems that there are no UT at all in this provider - all tests require real OpenStack installation to test. Couldn't find any mock / fake clients to do so.

also can you send you PR here https://github.com/kubernetes/cloud-provider-openstack too ?

Of course.

@mvladev mvladev mentioned this pull request Oct 31, 2018
Merged
@NickrenREN
Copy link
Contributor

sgtm, thanks @mvladev

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2018
@k8s-ci-robot k8s-ci-robot merged commit 0325662 into kubernetes:master Oct 31, 2018
@mvladev mvladev deleted the fix-cloud-provider-openstack branch October 31, 2018 12:25
@mvladev mvladev mentioned this pull request Oct 31, 2018
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 31, 2018
This was referenced Oct 31, 2018
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 1, 2018
@k8s-ci-robot
Merge pull request #70479 from mvladev/automated-cherry-pick-of-#7045…
53b8166 
…9-upstream-release-1.10

Automated cherry pick of #70459: fix openstack provider to handle only Cinder volumes
k8s-ci-robot added a commit that referenced this pull request Nov 1, 2018
@k8s-ci-robot
Merge pull request #70487 from mvladev/automated-cherry-pick-of-#7045…
a013eed 
…9-upstream-release-1.12

Automated cherry pick of #70459: fix openstack provider to handle only Cinder volumes
k8s-ci-robot added a commit that referenced this pull request Dec 3, 2018
@k8s-ci-robot
Merge pull request #70486 from mvladev/automated-cherry-pick-of-#7045…
18b82fa 
…9-upstream-release-1.11

Automated cherry pick of #70459: fix openstack provider to handle only Cinder volumes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FengyunPan2 FengyunPan2 FengyunPan2 approved these changes

@NickrenREN NickrenREN Awaiting requested review from NickrenREN

Assignees

@NickrenREN NickrenREN

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mvladev @idealhack @NickrenREN @k8s-ci-robot @adisky @FengyunPan2