-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: enable secure port and authn/z #69663
scheduler: enable secure port and authn/z #69663
Conversation
29b783a
to
08cdef5
Compare
de80b08
to
c440032
Compare
/retest |
New changes are detected. LGTM label has been removed. |
Enforces clean ownership of the channel.
de64334
to
1588af4
Compare
New changes are detected. LGTM label has been removed. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aveshagarwal, liggitt, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@sttts: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Review the full test history for this PR. Silence the bot with an |
@sttts I want to learn about the motivations behind deprecating the plain http (insecure!?) port. Can you point me to any related discussions about this? |
Deprecated: &DeprecatedOptions{ | ||
UseLegacyPolicyConfig: false, | ||
PolicyConfigMapNamespace: metav1.NamespaceSystem, | ||
}, | ||
} | ||
|
||
o.Authentication.RemoteKubeConfigFileOptional = true | ||
o.Authorization.RemoteKubeConfigFileOptional = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in addition to tolerating missing kubeconfig, this needed to tolerate forbidden failures in lookupMissingConfigInCluster
... nothing granted the scheduler delegated authentication permissions by default
xref #71743
Completes #67192.
This PR adds a secure port 10259 to the scheduler
Fixes #58983.