fix inconsistency in windows kernel proxy when updating hns policy

[delulu]

What this PR does / why we need it:

This PR removes the "svcInfo.policyApplied" check in cleaning up all the related HNS policies when a k8s service is removed.

Otherwise, kube proxy will go to an inconsistent state ( legacy HNS policy wont get removed in service cleanup, and new HNS policy creation will fail with error msg "The specified port already exists." ) :

1. when a k8s service is removed before all the HNS policies for this service are applied.

2. some HNS failure occurs during applying the HNS policies for this service.

Release note:

fix inconsistency in windows kernel proxy when updating HNS policy.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[feiskyer]

/ok-to-test
/kind bug

[feiskyer]

/ok-to-test

[feiskyer]

@delulu Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

[delulu]

I signed it

[delulu]

@feiskyer, thx for your tips. I already signed the CLA, how to ask the system to recheck my authorization?

[delulu]

/retest

[dineshgovindasamy]

Can you please add comment in this function that svcInfo.policyApplied check is not needed as we are trying to remove all policies?

[dineshgovindasamy]

/LGTM

[madhanrm]

/sig windows

[delulu]

@dineshgovindasamy I have added the code comment, please check again.

[madhanrm]

/lgtm

[delulu]

/assign @thockin

[thockin]

/approve

[thockin]

@kubernetes/sig-contributor-experience-bugs Why does this want my approval? Why is it not enough to get someone in the OWNERS of the file in question?

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

[delulu]

/retest

[madhanrm]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: delulu, dineshgovindasamy, madhanrm, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/proxy/OWNERS [thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment