-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct kubelet service file permission #66669
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
e023ddb
to
0906657
Compare
c4546b8
to
d5661cd
Compare
17275aa
to
31d8f3f
Compare
To fix below waring: systemd[1]: Configuration file /etc/systemd/system/kubelet.service is marked executable. Please remove executable permission bits. Proceeding anyway. Signed-off-by: Xiang Dai <[email protected]>
/assign @mikedanese |
/ok-to-test cc @mbohlool |
/sig release |
Test seems ok now @dims |
@daixiang0 looks like we need to patch up https://github.com/kubernetes/release/blob/master/rpm/kubelet.spec#L164 too |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: daixiang0, mikedanese The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dims done as kubernetes/release#640 |
@mikedanese @dims I found that %install section will change kubelet.service as 755, so i revert this and create as #69127:
|
To fix below waring:
7月 26 12:47:58 test-0.localdomain systemd[1]: Configuration file /etc/systemd/system/kubelet.service is marked executable. Please remove executable permission bits. Proceeding anyway.
The service file should be in 644 mode rather than 755.