Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #54674 #56384

Merged
merged 2 commits into from
Nov 28, 2017
Merged

Automated cherry pick of #54674 #56384

merged 2 commits into from
Nov 28, 2017

Conversation

andyzhangx
Copy link
Member

Cherry pick of #54674 on release-1.8.

#54674: support mount options in azure file

@andyzhangx
support mount options in azure file
1f9a73c 
use JoinMountOptions func

add a new test case

move const vars

fix fmt issue
@andyzhangx
add vers mountoptions and fix comments
5195afd
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 27, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andyzhangx
We suggest the following additional approver: brendandburns

Assign the PR to them by writing /assign @brendandburns in a comment when ready.

Associated issue: 54674

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Nov 27, 2017
@andyzhangx
Copy link
Member Author

/assign @rootfs

@jpbetz jpbetz added approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Nov 27, 2017
@andyzhangx andyzhangx mentioned this pull request Nov 27, 2017
Closed
@enisoc enisoc added this to the v1.8 milestone Nov 27, 2017
@enisoc enisoc added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Nov 27, 2017
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Labels Incomplete

@andyzhangx @brendandburns @jingxu97 @rootfs

Action required: This pull request requires label changes.

kind: Must specify exactly one of kind/bug, kind/cleanup or kind/feature.
sig owner: Must specify at least one label prefixed with sig/.

Help

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit dce7a2b into kubernetes:release-1.8 Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brendandburns brendandburns

@rootfs rootfs

@jingxu97 jingxu97

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/incomplete-labels priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
8 participants
@andyzhangx @k8s-github-robot @jpbetz @brendandburns @enisoc @rootfs @jingxu97 @k8s-ci-robot