update gRPC to pick up data race fix #53128

dixudx · 2017-09-27T09:39:46Z

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #53124

Special notes for your reviewer:

Release note:

update gRPC to v1.6.0 to pick up data race fix grpc/grpc-go#1316

k8s-ci-robot · 2017-09-27T09:39:53Z

Hi @dixudx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

caesarxuchao · 2017-09-28T20:41:18Z

/assign @roycaihw

k8s-ci-robot · 2017-09-28T20:41:19Z

@caesarxuchao: GitHub didn't allow me to assign the following users: roycaihw.

Note that only kubernetes members can be assigned.

In response to this:

/assign @roycaihw

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

caesarxuchao · 2017-09-28T20:41:34Z

/sig api-machinery

roycaihw · 2017-09-29T16:49:52Z

lgtm

caesarxuchao · 2017-09-29T17:18:44Z

Godeps/Godeps.json

-			"ImportPath": "google.golang.org/grpc/grpclb/grpc_lb_v1",
-			"Comment": "v1.3.0",
-			"Rev": "d2e1b51f33ff8c5e4a15560ff049d200e83726c5"
+			"ImportPath": "google.golang.org/grpc/grpclb/grpc_lb_v1/messages",


@dixudx do you know why the ImportPath changed?

@caesarxuchao It was grpc/grpc-go#1466 that made this changed.

dims · 2017-10-09T01:49:22Z

/ok-to-test

caesarxuchao · 2017-10-12T06:14:07Z

/lgtm

caesarxuchao · 2017-10-12T06:14:11Z

/retest

dixudx · 2017-10-16T09:33:15Z

ping @caesarxuchao @jbeda Rebased. PTAL. It's ready for a review. Thanks.

dixudx · 2017-10-16T12:51:44Z

/retest

k8s-ci-robot · 2017-10-16T13:04:40Z

@dixudx: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-cross	`e92d49b`	link	`/test pull-kubernetes-cross`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

dixudx · 2017-10-18T02:54:15Z

/retest

caesarxuchao · 2017-10-19T00:13:32Z

/lgtm

dixudx · 2017-10-20T07:10:22Z

ping @smarterclayton @wojtek-t for approval. Thanks

wojtek-t · 2017-10-20T07:27:50Z

/approve

k8s-github-robot · 2017-10-20T07:28:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, dixudx, wojtek-t

Associated issue: 53124

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [wojtek-t]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

k8s-github-robot · 2017-10-20T07:29:09Z

/test all [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2017-10-20T08:32:17Z

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

shyamjvs · 2017-10-23T11:23:10Z

This PR broke large clusters i.e size >= 100 (see #51099 (comment)) due to lower grpc page size limit.

@wojtek-t

…ps_fix_grpc_data_race Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Revert "update gRPC to pick up data race fix" Reverts kubernetes#53128 Fixes kubernetes#51099 cc @kubernetes/sig-api-machinery-bugs @wojtek-t @dixudx

@wojtek-t

…c_data_race Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Revert "update gRPC to pick up data race fix" Reverts kubernetes/kubernetes#53128 Fixes kubernetes/kubernetes#51099 cc @kubernetes/sig-api-machinery-bugs @wojtek-t @dixudx Kubernetes-commit: bc69c92de15c2457b3566bbede5b363328e0d640

@wojtek-t

…c_data_race Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Revert "update gRPC to pick up data race fix" Reverts kubernetes/kubernetes#53128 Fixes kubernetes/kubernetes#51099 cc @kubernetes/sig-api-machinery-bugs @wojtek-t @dixudx Kubernetes-commit: bc69c92de15c2457b3566bbede5b363328e0d640

@wojtek-t

…c_data_race Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Revert "update gRPC to pick up data race fix" Reverts kubernetes/kubernetes#53128 Fixes kubernetes/kubernetes#51099 cc @kubernetes/sig-api-machinery-bugs @wojtek-t @dixudx Kubernetes-commit: bc69c92de15c2457b3566bbede5b363328e0d640

@wojtek-t

…c_data_race Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Revert "update gRPC to pick up data race fix" Reverts kubernetes/kubernetes#53128 Fixes kubernetes/kubernetes#51099 cc @kubernetes/sig-api-machinery-bugs @wojtek-t @dixudx Kubernetes-commit: bc69c92de15c2457b3566bbede5b363328e0d640

@wojtek-t

…c_data_race Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Revert "update gRPC to pick up data race fix" Reverts kubernetes/kubernetes#53128 Fixes kubernetes/kubernetes#51099 cc @kubernetes/sig-api-machinery-bugs @wojtek-t @dixudx Kubernetes-commit: bc69c92de15c2457b3566bbede5b363328e0d640

@wojtek-t

…c_data_race Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Revert "update gRPC to pick up data race fix" Reverts kubernetes/kubernetes#53128 Fixes kubernetes/kubernetes#51099 cc @kubernetes/sig-api-machinery-bugs @wojtek-t @dixudx Kubernetes-commit: bc69c92de15c2457b3566bbede5b363328e0d640

@wojtek-t

…c_data_race Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Revert "update gRPC to pick up data race fix" Reverts kubernetes/kubernetes#53128 Fixes kubernetes/kubernetes#51099 cc @kubernetes/sig-api-machinery-bugs @wojtek-t @dixudx Kubernetes-commit: bc69c92de15c2457b3566bbede5b363328e0d640

@wojtek-t

…c_data_race Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Revert "update gRPC to pick up data race fix" Reverts kubernetes/kubernetes#53128 Fixes kubernetes/kubernetes#51099 cc @kubernetes/sig-api-machinery-bugs @wojtek-t @dixudx Kubernetes-commit: bc69c92de15c2457b3566bbede5b363328e0d640

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 27, 2017

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 27, 2017

k8s-github-robot assigned lavalamp and jbeda Sep 27, 2017

k8s-github-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 27, 2017

dixudx mentioned this pull request Sep 27, 2017

Update gRPC library to pick up data race fix #53124

Closed

k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Sep 28, 2017

caesarxuchao reviewed Sep 29, 2017

View reviewed changes

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 9, 2017

dixudx force-pushed the godeps_fix_grpc_data_race branch 2 times, most recently from 8b2569d to c479b6c Compare October 11, 2017 09:02

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2017

dixudx force-pushed the godeps_fix_grpc_data_race branch 2 times, most recently from e92d49b to 673f140 Compare October 12, 2017 03:11

k8s-ci-robot assigned caesarxuchao Oct 12, 2017

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2017

dixudx force-pushed the godeps_fix_grpc_data_race branch from 673f140 to cba09d9 Compare October 12, 2017 06:18

k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2017

dixudx force-pushed the godeps_fix_grpc_data_race branch from cba09d9 to b397c71 Compare October 12, 2017 07:24

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2017

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2017

update Godeps grpc to pick up data race fix

99e9ec1

dixudx force-pushed the godeps_fix_grpc_data_race branch from 481a0b2 to 99e9ec1 Compare October 16, 2017 09:55

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2017

k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2017

k8s-github-robot merged commit 70960a5 into kubernetes:master Oct 20, 2017

dixudx deleted the godeps_fix_grpc_data_race branch October 20, 2017 08:34

shyamjvs mentioned this pull request Oct 23, 2017

gRPC update causing failure of API calls with large responses #51099

Closed

shyamjvs mentioned this pull request Oct 23, 2017

Revert "update gRPC to pick up data race fix" #54400

Merged

ash2k mentioned this pull request Dec 19, 2017

Version bump to etcd v3.2.11, grpc v1.7.5 #57160

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update gRPC to pick up data race fix #53128

update gRPC to pick up data race fix #53128

dixudx commented Sep 27, 2017 •

edited

Loading

k8s-ci-robot commented Sep 27, 2017

caesarxuchao commented Sep 28, 2017

k8s-ci-robot commented Sep 28, 2017

caesarxuchao commented Sep 28, 2017

roycaihw commented Sep 29, 2017

caesarxuchao Sep 29, 2017

dixudx Sep 30, 2017

dims commented Oct 9, 2017

caesarxuchao commented Oct 12, 2017

caesarxuchao commented Oct 12, 2017

dixudx commented Oct 16, 2017

dixudx commented Oct 16, 2017

k8s-ci-robot commented Oct 16, 2017 •

edited

Loading

dixudx commented Oct 18, 2017

caesarxuchao commented Oct 19, 2017

dixudx commented Oct 20, 2017

wojtek-t commented Oct 20, 2017

k8s-github-robot commented Oct 20, 2017

k8s-github-robot commented Oct 20, 2017

k8s-github-robot commented Oct 20, 2017

shyamjvs commented Oct 23, 2017 •

edited

Loading

update gRPC to pick up data race fix #53128

update gRPC to pick up data race fix #53128

Conversation

dixudx commented Sep 27, 2017 • edited Loading

k8s-ci-robot commented Sep 27, 2017

caesarxuchao commented Sep 28, 2017

k8s-ci-robot commented Sep 28, 2017

caesarxuchao commented Sep 28, 2017

roycaihw commented Sep 29, 2017

caesarxuchao Sep 29, 2017

Choose a reason for hiding this comment

dixudx Sep 30, 2017

Choose a reason for hiding this comment

dims commented Oct 9, 2017

caesarxuchao commented Oct 12, 2017

caesarxuchao commented Oct 12, 2017

dixudx commented Oct 16, 2017

dixudx commented Oct 16, 2017

k8s-ci-robot commented Oct 16, 2017 • edited Loading

dixudx commented Oct 18, 2017

caesarxuchao commented Oct 19, 2017

dixudx commented Oct 20, 2017

wojtek-t commented Oct 20, 2017

k8s-github-robot commented Oct 20, 2017

k8s-github-robot commented Oct 20, 2017

k8s-github-robot commented Oct 20, 2017

shyamjvs commented Oct 23, 2017 • edited Loading

dixudx commented Sep 27, 2017 •

edited

Loading

k8s-ci-robot commented Oct 16, 2017 •

edited

Loading

shyamjvs commented Oct 23, 2017 •

edited

Loading