Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rev Calico's Typha daemon to v0.2.3 in add-on deployment. #48469

Merged
merged 1 commit into from
Jul 26, 2017
Merged

Rev Calico's Typha daemon to v0.2.3 in add-on deployment. #48469

merged 1 commit into from
Jul 26, 2017

Conversation

fasaxc
Copy link
Contributor

@fasaxc fasaxc commented Jul 4, 2017 •
edited
Loading

What this PR does / why we need it:

This PR revs the version of Calico's Typha daemon used in the calico-policy-controller add-on to the latest bug-fix release, which incorporates a critical bug fix.

Which issue this PR fixes

fixes #49473

Release note:

Rev version of Calico's Typha daemon used in add-on to v0.2.3 to pull in bug-fixes.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 4, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @fasaxc. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 4, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 4, 2017
@cblecker
Copy link
Member

cblecker commented Jul 4, 2017

/ok-to-test

@fasaxc Please review/sign the CLA, and comment back here when it's complete. Thank you!

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 4, 2017
@fasaxc
Copy link
Contributor Author

fasaxc commented Jul 4, 2017

@cblecker I've now been added to our corporate CLA.

@cblecker
Copy link
Member

cblecker commented Jul 4, 2017

@fasaxc Does the e-mail on the commit match your CLA and github account? Your account is still being reported as no CLA.

@fasaxc
Copy link
Contributor Author

fasaxc commented Jul 5, 2017

Ah, I think we used an old (Google group-based) CLA process (guess my colleagues are grandfathered in on that one). I'll get someone to e-sign the new CLA and comment when that's done.

@fasaxc
Copy link
Contributor Author

fasaxc commented Jul 7, 2017

OK, CLA is now in place.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 7, 2017
@dnardo
Copy link
Contributor

dnardo commented Jul 7, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2017
@fasaxc
Copy link
Contributor Author

fasaxc commented Jul 7, 2017

/assign @eparis

@fasaxc fasaxc mentioned this pull request Jul 10, 2017
Closed
@fasaxc
Copy link
Contributor Author

fasaxc commented Jul 10, 2017

Tests failed with a GCP quota error: #48688 I can't see how that would be related to my changes.

@fasaxc
Copy link
Contributor Author

fasaxc commented Jul 10, 2017

/retest

@dnardo
Copy link
Contributor

dnardo commented Jul 11, 2017

/assign @roberthbailey for approval.

@cblecker
Copy link
Member

/retest

1 similar comment
@fasaxc
Copy link
Contributor Author

fasaxc commented Jul 19, 2017

/retest

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2017
@fasaxc
Copy link
Contributor Author

fasaxc commented Jul 19, 2017 •
edited
Loading

There didn't seem to be any logs for the persistent CI failure so I tried rebasing the PR, which seems to have worked.

@dnardo
Copy link
Contributor

dnardo commented Jul 20, 2017

/assign @thockin

@dnardo
Copy link
Contributor

dnardo commented Jul 20, 2017

@thockin this needs approval

@roberthbailey
Copy link
Contributor

/approve

@fasaxc fasaxc mentioned this pull request Jul 24, 2017
Closed
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2017
@fasaxc
Copy link
Contributor Author

fasaxc commented Jul 26, 2017

I added an issue and linked in the PR comment.

@fasaxc
Copy link
Contributor Author

fasaxc commented Jul 26, 2017

Did I use the right syntax? The bot still seems to be upset.

@caseydavenport
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caseydavenport, dnardo, fasaxc, roberthbailey

Associated issue: 49473

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@fasaxc
Copy link
Contributor Author

fasaxc commented Jul 26, 2017

/retest

1 similar comment
@fasaxc
Copy link
Contributor Author

fasaxc commented Jul 26, 2017

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 48360, 48469, 49576, 49516, 49558)

@k8s-github-robot k8s-github-robot merged commit 4a65675 into kubernetes:master Jul 26, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 26, 2017 •
edited
Loading

@fasaxc: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-etcd3 d2882a8 link /test pull-kubernetes-e2e-gce-etcd3

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fasaxc fasaxc deleted the rev-typha branch July 27, 2017 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jbeda jbeda

@caseydavenport caseydavenport

@thockin thockin

@eparis eparis

@dnardo dnardo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version of Calico's typha daemon in add-on needs to be revved to pick up critical fixes
10 participants
@fasaxc @k8s-ci-robot @cblecker @dnardo @roberthbailey @caseydavenport @k8s-github-robot @jbeda @thockin @eparis