Removed old scheduler constructor. #45472
Conversation
|
This change is |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/S
k82cn
changed the title
k8s-github-robot
added
size/L
k82cn
changed the title
| s := &Scheduler{ | ||
| config: c, | ||
| } | ||
| metrics.Register() |
There was a problem hiding this comment.
What is registering metrics now?
There was a problem hiding this comment.
New is replaced by NewFromConfigurator now. New is not use in kube-scheduler but tests, I'm updating code for them.
plugin/pkg/scheduler/testutil.go
Outdated
|
|
||
| type FakeConfigurator struct { | ||
| Config *Config | ||
| PriorityConfigs []algorithm.PriorityConfig |
There was a problem hiding this comment.
All of these seems to be unused in all usecases.
Unless you see a good reason to have them (I don't), I really suggest removing all of these fields.
And all accessort functions can simple return nils (which they already do) or errors "not implemented" (if it won't break anything).
There was a problem hiding this comment.
Good point, I'll update it.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k82cn, wojtek-t
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 41903, 45311, 45474, 45472, 45501) |
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes # N/ARelease note: