Skip to content

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Feb 16, 2015

No one outside of the apiserver package can create or inspect the APIRequestInfoResolver. OpenShift would like to do both: "create my own APIRequestInfoResolver", "what APIPrefixes are being used", "what resources are recognized", etc.

@smarterclayton pretty small, but needed for unification.

@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@deads2k
Copy link
Contributor Author

deads2k commented Feb 16, 2015

lawyer bot is fast!

@smarterclayton
Copy link
Contributor

I'm increasingly disatisfied with apirequestinforesolver. Let me look at this but I may ask you to start mitigating that concern.

On Feb 16, 2015, at 1:57 PM, David Eads [email protected] wrote:

No one outside of the apiserver package can create or inspect the APIRequestInfoResolver. OpenShift would like to do both: "create my own APIRequestInfoResolver", "what APIPrefixes are being used", "what resources are recognized", etc.

@smarterclayton pretty small, but needed for unification.

You can view, comment on, or merge this pull request online at:

#4461

Commit Summary

expose creation APIRequestInfoResolver
File Changes

M pkg/apiserver/handlers.go (8)
Patch Links:

https://github.com/GoogleCloudPlatform/kubernetes/pull/4461.patch
https://github.com/GoogleCloudPlatform/kubernetes/pull/4461.diff

Reply to this email directly or view it on GitHub.

@smarterclayton smarterclayton self-assigned this Feb 16, 2015
@smarterclayton
Copy link
Contributor

I guess this is fine as is. LGTM

@smarterclayton smarterclayton added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2015
smarterclayton added a commit that referenced this pull request Feb 16, 2015
expose creation APIRequestInfoResolver
@smarterclayton smarterclayton merged commit f27bcf5 into kubernetes:master Feb 16, 2015
@deads2k deads2k deleted the deads-expose-info-resolver branch February 17, 2015 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm "Looks good to me", indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants