Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply #40326 on release-1.4: Prep node_e2e for GCI to COS name change #41088

Merged
merged 1 commit into from
Feb 9, 2017
Merged

apply #40326 on release-1.4: Prep node_e2e for GCI to COS name change #41088

merged 1 commit into from
Feb 9, 2017

Conversation

jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Feb 7, 2017 •
edited
Loading 

Prep node_e2e for GCI to COS name change

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 7, 2017
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Feb 7, 2017
@jessfraz jessfraz mentioned this pull request Feb 7, 2017
Merged
@jessfraz jessfraz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Feb 7, 2017
@jessfraz jessfraz added this to the v1.4 milestone Feb 7, 2017
@jessfraz jessfraz added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Feb 7, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@tmrts
Copy link
Contributor

tmrts commented Feb 7, 2017

/approve

@tmrts
Copy link
Contributor

tmrts commented Feb 7, 2017

Cherry pick LGTM

@Random-Liu PTAL

@Random-Liu
Copy link
Member

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: Random-Liu, jessfraz, tmrts

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2017
@mtaufen
Copy link
Contributor

mtaufen commented Feb 7, 2017

Thanks @jessfraz!

@jessfraz
Copy link
Contributor Author

jessfraz commented Feb 9, 2017

merging since all green

@jessfraz jessfraz merged commit dabd200 into kubernetes:release-1.4 Feb 9, 2017
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@jessfraz jessfraz deleted the cherry-pick-40326 branch February 9, 2017 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tmrts tmrts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
8 participants
@jessfraz @k8s-reviewable @tmrts @Random-Liu @k8s-github-robot @mtaufen @k8s-cherrypick-bot @k8s-ci-robot