Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fluentd a critical pod #41035

Merged
merged 1 commit into from
Feb 13, 2017
Merged

Conversation

vishh
Copy link
Contributor

@vishh vishh commented Feb 6, 2017

For #40573
Based on #40655 (comment)

If `experimentalCriticalPodAnnotation` feature gate is set to true, fluentd pods will not be evicted by the kubelet.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 6, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 6, 2017
@piosz piosz assigned piosz and unassigned crassirostris Feb 6, 2017
@@ -15,6 +15,11 @@ spec:
k8s-app: fluentd-gcp
kubernetes.io/cluster-service: "true"
version: v1.35
# This annotation ensures that fluentd does not get evicted if the node
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update also cluster/saltbase/salt/fluentd-gcp/fluentd-gcp.yaml. See comment from the first line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Sorry and thanks for pointing out.

Signed-off-by: Vishnu kannan <[email protected]>
@piosz
Copy link
Member

piosz commented Feb 6, 2017

LGTM

@piosz
Copy link
Member

piosz commented Feb 6, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2017
@vishh vishh added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: piosz, vishh

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@vishh
Copy link
Contributor Author

vishh commented Feb 6, 2017

@k8s-bot kops aws e2e test this

@vishh
Copy link
Contributor Author

vishh commented Feb 6, 2017

@k8s-bot gce etcd3 e2e test this

2 similar comments
@vishh
Copy link
Contributor Author

vishh commented Feb 6, 2017

@k8s-bot gce etcd3 e2e test this

@crassirostris
Copy link

@k8s-bot gce etcd3 e2e test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit e80afed into kubernetes:master Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants