Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replica set conditions API #33905

Merged
merged 3 commits into from
Oct 12, 2016
Merged

Replica set conditions API #33905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0701232
api: add Conditions in replication controllers
0xmichalis Sep 29, 2016
63a6ce3
extensions: add Conditions in replica sets
0xmichalis Sep 29, 2016
5589469
Generated code for RS/RC conditions
0xmichalis Oct 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 80 additions & 0 deletions api/openapi-spec/root_swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28176,6 +28176,39 @@
}
}
},
"v1.ReplicationControllerCondition": {
"description": "ReplicationControllerCondition describes the state of a replication controller at a certain point.",
"required": [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have been confused about the word Condition until i found this PR. I was thinking something like a predicate or cirumstance that led to something. Should we rather call it ReplicationControllerState ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, that ship has sailed. The convention is "condition".

noun
1.
the state of something, especially with regard to its appearance, quality, or working order.

"State" is equally ambiguous.

"type",
"status"
],
"properties": {
"lastProbeTime": {
"description": "Last time we probed the condition.",
"$ref": "#/definitions/unversioned.Time"
},
"lastTransitionTime": {
"description": "The last time the condition transitioned from one status to another.",
"$ref": "#/definitions/unversioned.Time"
},
"message": {
"description": "A human readable message indicating details about the transition.",
"type": "string"
},
"reason": {
"description": "The reason for the condition's last transition.",
"type": "string"
},
"status": {
"description": "Status of the condition, one of True, False, Unknown.",
"type": "string"
},
"type": {
"description": "Type of replication controller condition.",
"type": "string"
}
}
},
"v1.ReplicationControllerList": {
"description": "ReplicationControllerList is a collection of replication controllers.",
"required": [
Expand Down Expand Up @@ -28232,6 +28265,13 @@
"type": "integer",
"format": "int32"
},
"conditions": {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call this states

"description": "Represents the latest available observations of a replication controller's current state.",
"type": "array",
"items": {
"$ref": "#/definitions/v1.ReplicationControllerCondition"
}
},
"fullyLabeledReplicas": {
"description": "The number of pods that have labels matching the labels of the pod template of the replication controller.",
"type": "integer",
Expand Down Expand Up @@ -30052,6 +30092,39 @@
}
}
},
"v1beta1.ReplicaSetCondition": {
"description": "ReplicaSetCondition describes the state of a replica set at a certain point.",
"required": [
"type",
"status"
],
"properties": {
"lastProbeTime": {
"description": "Last time we probed the condition.",
"$ref": "#/definitions/unversioned.Time"
},
"lastTransitionTime": {
"description": "The last time the condition transitioned from one status to another.",
"$ref": "#/definitions/unversioned.Time"
},
"message": {
"description": "A human readable message indicating details about the transition.",
"type": "string"
},
"reason": {
"description": "The reason for the condition's last transition.",
"type": "string"
},
"status": {
"description": "Status of the condition, one of True, False, Unknown.",
"type": "string"
},
"type": {
"description": "Type of replica set condition.",
"type": "string"
}
}
},
"v1beta1.ReplicaSetList": {
"description": "ReplicaSetList is a collection of ReplicaSets.",
"required": [
Expand Down Expand Up @@ -30105,6 +30178,13 @@
"type": "integer",
"format": "int32"
},
"conditions": {
"description": "Represents the latest available observations of a replica set's current state.",
"type": "array",
"items": {
"$ref": "#/definitions/v1beta1.ReplicaSetCondition"
}
},
"fullyLabeledReplicas": {
"description": "The number of pods that have labels matching the labels of the pod template of the replicaset.",
"type": "integer",
Expand Down
40 changes: 40 additions & 0 deletions api/openapi-spec/v1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14679,6 +14679,39 @@
}
}
},
"v1.ReplicationControllerCondition": {
"description": "ReplicationControllerCondition describes the state of a replication controller at a certain point.",
"required": [
"type",
"status"
],
"properties": {
"lastProbeTime": {
"description": "Last time we probed the condition.",
"$ref": "#/definitions/unversioned.Time"
},
"lastTransitionTime": {
"description": "The last time the condition transitioned from one status to another.",
"$ref": "#/definitions/unversioned.Time"
},
"message": {
"description": "A human readable message indicating details about the transition.",
"type": "string"
},
"reason": {
"description": "The reason for the condition's last transition.",
"type": "string"
},
"status": {
"description": "Status of the condition, one of True, False, Unknown.",
"type": "string"
},
"type": {
"description": "Type of replication controller condition.",
"type": "string"
}
}
},
"v1.ReplicationControllerList": {
"description": "ReplicationControllerList is a collection of replication controllers.",
"required": [
Expand Down Expand Up @@ -14735,6 +14768,13 @@
"type": "integer",
"format": "int32"
},
"conditions": {
"description": "Represents the latest available observations of a replication controller's current state.",
"type": "array",
"items": {
"$ref": "#/definitions/v1.ReplicationControllerCondition"
}
},
"fullyLabeledReplicas": {
"description": "The number of pods that have labels matching the labels of the pod template of the replication controller.",
"type": "integer",
Expand Down
40 changes: 40 additions & 0 deletions api/openapi-spec/v1beta1.extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7798,6 +7798,39 @@
}
}
},
"v1beta1.ReplicaSetCondition": {
"description": "ReplicaSetCondition describes the state of a replica set at a certain point.",
"required": [
"type",
"status"
],
"properties": {
"lastProbeTime": {
"description": "Last time we probed the condition.",
"$ref": "#/definitions/unversioned.Time"
},
"lastTransitionTime": {
"description": "The last time the condition transitioned from one status to another.",
"$ref": "#/definitions/unversioned.Time"
},
"message": {
"description": "A human readable message indicating details about the transition.",
"type": "string"
},
"reason": {
"description": "The reason for the condition's last transition.",
"type": "string"
},
"status": {
"description": "Status of the condition, one of True, False, Unknown.",
"type": "string"
},
"type": {
"description": "Type of replica set condition.",
"type": "string"
}
}
},
"v1beta1.ReplicaSetList": {
"description": "ReplicaSetList is a collection of ReplicaSets.",
"required": [
Expand Down Expand Up @@ -7851,6 +7884,13 @@
"type": "integer",
"format": "int32"
},
"conditions": {
"description": "Represents the latest available observations of a replica set's current state.",
"type": "array",
"items": {
"$ref": "#/definitions/v1beta1.ReplicaSetCondition"
}
},
"fullyLabeledReplicas": {
"description": "The number of pods that have labels matching the labels of the pod template of the replicaset.",
"type": "integer",
Expand Down
43 changes: 43 additions & 0 deletions api/swagger-spec/extensions_v1beta1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10348,6 +10348,49 @@
"type": "integer",
"format": "int64",
"description": "ObservedGeneration reflects the generation of the most recently observed ReplicaSet."
},
"conditions": {
"type": "array",
"items": {
"$ref": "v1beta1.ReplicaSetCondition"
},
"description": "Represents the latest available observations of a replica set's current state."
}
}
},
"v1beta1.ReplicaSetCondition": {
"id": "v1beta1.ReplicaSetCondition",
"description": "ReplicaSetCondition describes the state of a replica set at a certain point.",
"required": [
"type",
"status"
],
"properties": {
"type": {
"type": "string",
"description": "Type of replica set condition."
},
"status": {
"type": "string",
"description": "Status of the condition, one of True, False, Unknown."
},
"lastProbeTime": {
"type": "string",
"format": "date-time",
"description": "Last time we probed the condition."
},
"lastTransitionTime": {
"type": "string",
"format": "date-time",
"description": "The last time the condition transitioned from one status to another."
},
"reason": {
"type": "string",
"description": "The reason for the condition's last transition."
},
"message": {
"type": "string",
"description": "A human readable message indicating details about the transition."
}
}
},
Expand Down
43 changes: 43 additions & 0 deletions api/swagger-spec/v1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19135,6 +19135,49 @@
"type": "integer",
"format": "int64",
"description": "ObservedGeneration reflects the generation of the most recently observed replication controller."
},
"conditions": {
"type": "array",
"items": {
"$ref": "v1.ReplicationControllerCondition"
},
"description": "Represents the latest available observations of a replication controller's current state."
}
}
},
"v1.ReplicationControllerCondition": {
"id": "v1.ReplicationControllerCondition",
"description": "ReplicationControllerCondition describes the state of a replication controller at a certain point.",
"required": [
"type",
"status"
],
"properties": {
"type": {
"type": "string",
"description": "Type of replication controller condition."
},
"status": {
"type": "string",
"description": "Status of the condition, one of True, False, Unknown."
},
"lastProbeTime": {
"type": "string",
"format": "date-time",
"description": "Last time we probed the condition."
},
"lastTransitionTime": {
"type": "string",
"format": "date-time",
"description": "The last time the condition transitioned from one status to another."
},
"reason": {
"type": "string",
"description": "The reason for the condition's last transition."
},
"message": {
"type": "string",
"description": "A human readable message indicating details about the transition."
}
}
},
Expand Down
Loading