Doc API group suffix, add test to catch new groups #32315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liggitt
force-pushed
the
api-group-suffix
branch
from
5316c0c
to
fd1b4d3
Compare
k8s-github-robot
added
kind/design
liggitt
force-pushed
the
api-group-suffix
branch
from
fd1b4d3
to
a94493d
Compare
|
cc @kubernetes/sig-api-machinery @lavalamp @bgrant0607 @thockin |
liggitt
force-pushed
the
api-group-suffix
branch
from
a94493d
to
527f033
Compare
liggitt
added
release-note-none
| @@ -80,7 +80,7 @@ expected to be programmatically convertible to the name of the resource using | |||
| the following conversion. Kinds are expected to be of the form | |||
| `<CamelCaseKind>`, and the `APIVersion` for the object is expected to be | |||
| `<api-group>/<api-version>`. To prevent collisions, it's expected that you'll | |||
| use a fully qualified domain name for the API group, e.g. `example.com`. | |||
| use a DNS name of at least three segments for the API group, e.g. `stable.example.com`. | |||
|
|
|||
| For example `stable.example.com/v1` | |||
There was a problem hiding this comment.
Maybe stable is a bad example now.
There was a problem hiding this comment.
changed to "mygroup.example.com"... better suggestions welcome
liggitt
force-pushed
the
api-group-suffix
branch
from
527f033
to
620cc66
Compare
|
GCE e2e build/test passed for commit 620cc66. |
krousey
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 620cc66. |
|
Automatic merge from submit-queue |
xingzhou
pushed a commit
to xingzhou/kubernetes
that referenced
this pull request
Dec 15, 2016
Automatic merge from submit-queue Doc API group suffix, add test to catch new groups Spawned from discussion in kubernetes#31887 Doc and add tests to ensure new API groups are suffixed. Also changed the doc to reference an API group containing the suffix as a starting point for new API groups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spawned from discussion in #31887
Doc and add tests to ensure new API groups are suffixed.
Also changed the doc to reference an API group containing the suffix as a starting point for new API groups.
This change is