Create a file from data stored in gobindata to fix kubectl-based exam… #31883
Conversation
gmarek
added
retest-not-required
release-note-none
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. |
|
LGTM |
wojtek-t
added
the
lgtm
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. |
k8s-github-robot
added
the
size/M
| return fmt.Errorf("Failed to read gobindata from %v", gobindataPath) | ||
| } | ||
| fullPath := filepath.Join(TestContext.OutputDir, outputFilename) | ||
| err := os.MkdirAll(filepath.Dir(fullPath), 0777) |
There was a problem hiding this comment.
is 0755 enough? (i am ok with leaving it as 0777, but just asking to learn if we needed it)
There was a problem hiding this comment.
Maybe - I don't know. We can change it needed or deemed dangerous.
|
LGTM! 👍 |
|
GCE e2e build/test passed for commit 02985c9. |
|
Automatic merge from submit-queue |
|
Seems like |
Fix #31539
Adding 1.4 milestone as this fixes P0 flake issue (test completely broken by moving to gobindata). @pwittrock
cc @jayunit100
This change is