change all PredicateFunc to use SelectionPredicate #30529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ref: #29888 |
k8s-github-robot
added
size/L
hongchaodeng
force-pushed
the
r1
branch
6 times, most recently
from
137c704 to
1c71477
Compare
k8s-github-robot
added
size/XL
|
registry unit test failing |
|
@smarterclayton |
| return labels.Set{} | ||
| // SelectableFields returns a field set that can be used for filter selection | ||
| func SelectableFields(obj *extensions.ThirdPartyResourceData) fields.Set { | ||
| return fields.Set{} |
There was a problem hiding this comment.
It would be more correct to return nil here to avoid an allocation. Selectable fields is read only, correct?
There was a problem hiding this comment.
Yes.
I had some thoughts on fields set:
- If no selectable fields, return nil
- An object has static selectable fields. We can store it someway.
Let me do the first one.
|
@smarterclayton |
smarterclayton
added
lgtm
|
GCE e2e build/test passed for commit eb516fb. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit eb516fb. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
This change is