Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReplicaSetSpec.Template shouldn't be a pointer. #22758

Merged
merged 2 commits into from
Mar 10, 2016
Merged

ReplicaSetSpec.Template shouldn't be a pointer. #22758

merged 2 commits into from
Mar 10, 2016

Conversation

madhusudancs
Copy link
Contributor

PodTemplateSpec should be consistent for all the types in extensions/v1beta1.

See PR #19510.

cc @bgrant0607

@madhusudancs madhusudancs added this to the v1.2 milestone Mar 9, 2016
@madhusudancs madhusudancs added cherrypick-candidate priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Mar 9, 2016
@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 9, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 9, 2016

GCE e2e build/test failed for commit b94b1d3b979df514bde5d52673fc5b52328549c6.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@bgrant0607
Copy link
Member

Tests failed

@bgrant0607
Copy link
Member

Test build failed

@bgrant0607
Copy link
Member

Will need to be rebased after #22724 merges.

@madhusudancs madhusudancs changed the title ReplicaSetSpec.Templatec shouldn't be a pointer. ReplicaSetSpec.Template shouldn't be a pointer. Mar 10, 2016
@madhusudancs madhusudancs force-pushed the replicaset-nonpointer-template branch from 4b43c6a to f2f90c7 Compare March 10, 2016 04:59
@madhusudancs
Copy link
Contributor Author

@bgrant0607 @mikedanese PTAL.

Tests fixed.

@k8s-github-robot
Copy link

Labelling this PR as size/L

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 10, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 10, 2016

GCE e2e build/test failed for commit 4b43c6a066eb4ebbff315f5e2acd3c5d6e660b39.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@k8s-bot
Copy link

k8s-bot commented Mar 10, 2016

GCE e2e build/test failed for commit f2f90c78eeb0c416f0e4c87c914cc4f4e8b6ea2f.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@liggitt liggitt mentioned this pull request Mar 10, 2016
Closed
85 tasks
@bgrant0607
Copy link
Member

@madhusudancs All the tests failed.

@bgrant0607
Copy link
Member 

# k8s.io/kubernetes/test/e2e
_output/local/go/src/k8s.io/kubernetes/test/e2e/util.go:1834: cannot use "k8s.io/kubernetes/pkg/api".PodTemplateSpec literal (type *"k8s.io/kubernetes/pkg/api".PodTemplateSpec) as type "k8s.io/kubernetes/pkg/api".PodTemplateSpec in field value
!!! Error in /workspace/kubernetes/hack/lib/golang.sh:433
  'go install "${goflags[@]:+${goflags[@]}}" -ldflags "${goldflags}" "${nonstatics[@]:+${nonstatics[@]}}"' exited with status 2

@madhusudancs
ReplicaSetSpec.Template shouldn't be a pointer.
db48dcf 
PodTemplateSpec should be consistent for all the types in extensions/v1beta1.

See PR kubernetes#19510.
@madhusudancs
Auto-generated code.
6fc1837
@madhusudancs madhusudancs force-pushed the replicaset-nonpointer-template branch from f2f90c7 to 6fc1837 Compare March 10, 2016 05:24
@k8s-bot
Copy link

k8s-bot commented Mar 10, 2016

GCE e2e build/test passed for commit 6fc1837.

@madhusudancs
Copy link
Contributor Author

@bgrant0607 Sorry about that. Tests are all passing now. PTAL.

@bgrant0607
Copy link
Member

LGTM, thanks

@bgrant0607 bgrant0607 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Mar 10, 2016

GCE e2e build/test passed for commit 6fc1837.

@ncdc
Copy link
Member

ncdc commented Mar 10, 2016

Merging

ncdc added a commit that referenced this pull request Mar 10, 2016
@ncdc
Merge pull request #22758 from madhusudancs/replicaset-nonpointer-tem…
cdd3395 
…plate

ReplicaSetSpec.Template shouldn't be a pointer.
@ncdc ncdc merged commit cdd3395 into kubernetes:master Mar 10, 2016
@bgrant0607 bgrant0607 added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 11, 2016
eparis added a commit to eparis/kubernetes that referenced this pull request Mar 11, 2016
@eparis
Merge pull request kubernetes#22758 from madhusudancs/replicaset-nonp…
610dbbd 
…ointer-template

ReplicaSetSpec.Template shouldn't be a pointer.

conflict in type.go with HEAD v release-1.2 in a comment. Fixed by hand
@eparis eparis mentioned this pull request Mar 11, 2016
Merged
@eparis
Copy link
Contributor

eparis commented Mar 11, 2016

This PR was sucessfully cherry picked in PR #22855
please verify that the release-1.2 branch contains these changes as you would expect and contact @eparis if there appear to be problems.

@eparis eparis removed cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Mar 11, 2016
metahertz pushed a commit to metahertz/kubernetes that referenced this pull request Apr 4, 2016
@eparis @TrXuk
Merge pull request kubernetes#22758 from madhusudancs/replicaset-nonp…
e7c0196 
…ointer-template

ReplicaSetSpec.Template shouldn't be a pointer.

conflict in type.go with HEAD v release-1.2 in a comment. Fixed by hand
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@eparis
Merge pull request kubernetes#22758 from madhusudancs/replicaset-nonp…
b4df8d6 
…ointer-template

ReplicaSetSpec.Template shouldn't be a pointer.

conflict in type.go with HEAD v release-1.2 in a comment. Fixed by hand
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
@eparis
Merge pull request kubernetes#22758 from madhusudancs/replicaset-nonp…
a272571 
…ointer-template

ReplicaSetSpec.Template shouldn't be a pointer.

conflict in type.go with HEAD v release-1.2 in a comment. Fixed by hand
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikedanese mikedanese

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
9 participants
@madhusudancs @k8s-github-robot @k8s-bot @bgrant0607 @ncdc @eparis @k8s-teamcity-mesosphere @mikedanese @googlebot