kube-up: Refactor SSL cert helpers into common#20642
kube-up: Refactor SSL cert helpers into common#20642k8s-github-robot merged 2 commits intokubernetes:masterfrom
Conversation
Next step in the the GCE/AWS harmonization
|
Created a tracking issue for this: #20643 |
|
Labelling this PR as size/L |
k8s-github-robot
added
the
size/L
|
GCE e2e build/test failed for commit 732e76f. |
|
GCE e2e build/test failed for commit 732e76f. |
cluster/common.sh
Outdated
| local -r cert_ip="${1}" | ||
|
|
||
| # Determine extra certificate names for master | ||
| local octets=($(echo "$SERVICE_CLUSTER_IP_RANGE" | sed -e 's|/.*||' -e 's/\./ /g')) |
There was a problem hiding this comment.
${SERVICE_CLUSTER_IP_RANGE}
|
One minor nit, feel free to self LGTM when fixed. |
|
Thanks brendan! LGTM-ing it. |
justinsb
added
the
lgtm
|
GCE e2e build/test failed for commit ba415c1. |
|
GCE e2e build/test failed for commit ba415c1. |
|
Travis continuous integration appears to have missed, closing and re-opening to trigger it |
|
GCE e2e build/test failed for commit ba415c1. |
|
GCE e2e test build/test passed for commit ba415c1. |
|
Oddly, this isn't in the submit queue either... Going to try a slower close & reopen |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit ba415c1. |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
allow patching configapi using oc patch Origin-commit: 70c96cbe60f66b151bb65642745e9364b57f236f
allow patching configapi using oc patch Origin-commit: 70c96cbe60f66b151bb65642745e9364b57f236f
5 participants
Next step in the the GCE/AWS harmonization