Send update events from service-controller. #20607
Conversation
|
Labelling this PR as size/S |
k8s-github-robot
added
the
size/S
There was a problem hiding this comment.
Reason should be camel case https://github.com/kubernetes/kubernetes/blob/master/docs/devel/api-conventions.md#events
|
These could all have the same reason UpdatingService and describe why in the message |
There was a problem hiding this comment.
This could use a better message
bprashanth
force-pushed
the
svccontroller_events
branch
from
9ff93fc to
33654c8
Compare
I tried that initially and though having UpdateService and a message like foo changed from x -> y was redundant. Thoughts? |
|
GCE e2e test build/test passed for commit 9ff93fcd4dca3acf00aae7e266ec806cdfe70da1. |
|
It would make searching/grepping somewhat easier to have a string that is common across all of these events. It's not super important |
mikedanese
added
the
lgtm
|
GCE e2e test build/test passed for commit 33654c8. |
|
@k8s-bot test this issue: #IGNORE Tests have been pending for 24 hours |
|
GCE e2e test build/test passed for commit 33654c8. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 33654c8. |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
5 participants
@maisem since I noticed you took #20547