-
Notifications
You must be signed in to change notification settings - Fork 41.5k
Implement container restart policy rules #132642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @yuanwang04. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/sig node |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
/hold The current changelog entry incorrectly implies that enabling the -Introduces container level restart rules in the API under feature gate `ContainerRestartRules`. Action required to turn on the feature gate to use container restart rules.
+Added a mechanism for configurable container restarts: _container level restart rules_. This is an alpha feature behind the `ContainerRestartRules` feature gate. |
/remove-sig api-machinery |
170db11
to
a1d5b5d
Compare
a1d5b5d
to
cccbb6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes quickly! I just have one wording comment.
/approve |
cccbb6f
to
b34f878
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/hold for @haircommander 's lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, SergeyKanzhelev, yuanwang04 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/unhold |
LGTM label has been added. Git tree hash: f01d052fa0cf6821f65bc8df3a398b44196562c9
|
@yuanwang04: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/skip |
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
Which issue(s) this PR is related to:
KEP: kubernetes/enhancements#5307
Special notes for your reviewer:
The API shape is outlined in https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/5307-container-restart-policy#design-details and discussed in kubernetes/enhancements#5308
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: