-
Notifications
You must be signed in to change notification settings - Fork 41.7k
[KEP-2400] Add a container_swap_limit_bytes metric #132348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KEP-2400] Add a container_swap_limit_bytes metric #132348
Conversation
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@iholder101: GitHub didn't allow me to request PR reviews from the following users: yuanwang04. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
79cf3a2 to
4a51da3
Compare
|
/test pull-kubernetes-unit-windows-master |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 778e43f05c4e5a310aaa4ee00ef1167f9d325f15
|
Signed-off-by: Itamar Holder <[email protected]>
Signed-off-by: Itamar Holder <[email protected]>
Signed-off-by: Itamar Holder <[email protected]>
fed3322 to
1ac60e3
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: 6f4f3370680c7d9c1525f6e014db016a79e0ede1
|
|
/retest |
|
Hey @dashpole! Is there something missing from your side? [1] #132348 (comment) |
dashpole
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
for sig-instrumentation
|
@SergeyKanzhelev would you be willing to approve this? Thanks! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ajaysundark, dashpole, dchen1107, iholder101 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/sig node
What this PR does / why we need it:
Swap metrics were originally added as part of #118865.
This PR adds a
container_swap_limit_bytesto report the calculated swap limit for each container and be available at the/metrics/resourceendpoint.After this is merged, we can consider adding this as part of
kubectl top pod/node --show-swap, as a follow-up to #129458.This is NOT a blocker for KEP-2400 GA, but rather a nice-to-have addition.
Which issue(s) this PR is related to:
Fixes #132228
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: