Skip to content

Conversation

@dims
Copy link
Member

@dims dims commented Mar 22, 2025

Fix for the the following error:
https://storage.googleapis.com/k8s-triage/index.html?text=container_metrics_test.go%3A119&xtext=container_spec_memory_swap_limit_bytes

from the logs:

[FAILED] Timed out after 60.001s.
The function passed to Eventually returned the following error:
    <*url.Error | 0x40009356b0>: 
    Get "http://i-0784eddc5b539f8e0:10255/metrics/cadvisor": dial tcp: lookup i-0784eddc5b539f8e0 on 172.31.0.2:53: no such host
    {
        Op: "Get",
        URL: "http://i-0784eddc5b539f8e0:10255/metrics/cadvisor",
        Err: <*net.OpError | 0x400054e910>{
            Op: "dial",
            Net: "tcp",
            Source: nil,
            Addr: nil,
            Err: <*net.DNSError | 0x400054e8c0>{
                UnwrapErr: nil,
                Err: "no such host",
                Name: "i-0784eddc5b539f8e0",
                Server: "172.31.0.2:53",
                IsTimeout: false,
                IsTemporary: false,
                IsNotFound: true,
            },
        },
    }
In [It] at: k8s.io/kubernetes/test/e2e_node/container_metrics_test.go:119 @ 03/21/25 03:16:17.564

The DNS lookup may not work properly, we currently use a pattern, so let's not invent a new one just for this test.

problem introduced by the same PR! #126213

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 22, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 22, 2025
@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 22, 2025
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2025
@dims
Copy link
Member Author

dims commented Mar 22, 2025

cc @bitoku @haircommander
/assign @SergeyKanzhelev @pacoxu

@dims
Copy link
Member Author

dims commented Mar 22, 2025

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 22, 2025
@dims
Copy link
Member Author

dims commented Mar 22, 2025

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 22, 2025
@dims
Copy link
Member Author

dims commented Mar 23, 2025

/retest

Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 3675576b3bdadfe283effccb53d479495f1384c8

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, tzneal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims
Copy link
Member Author

dims commented Mar 23, 2025

/milestone v1.33

@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Mar 23, 2025
@k8s-ci-robot k8s-ci-robot merged commit dab4af9 into kubernetes:master Mar 23, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Done in SIG Node CI/Test Board Mar 23, 2025
@haircommander
Copy link
Contributor

Thanks @dims !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Archived in project
Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants