-
Notifications
You must be signed in to change notification settings - Fork 42.3k
Use established pattern for kubelet metrics url #130998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use established pattern for kubelet metrics url #130998
Conversation
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
cc @bitoku @haircommander |
|
/release-note-none |
|
/priority critical-urgent |
|
/retest |
tzneal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
LGTM label has been added. DetailsGit tree hash: 3675576b3bdadfe283effccb53d479495f1384c8 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, tzneal The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/milestone v1.33 |
|
Thanks @dims ! |
Fix for the the following error:
https://storage.googleapis.com/k8s-triage/index.html?text=container_metrics_test.go%3A119&xtext=container_spec_memory_swap_limit_bytes
from the logs:
The DNS lookup may not work properly, we currently use a pattern, so let's not invent a new one just for this test.
problem introduced by the same PR! #126213
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: