KEP-1880 Multiple Service CIDRs: Graduate to Beta (1/2)

[aojea]

/kind feature

Add missing criteria and close some pending work, a follow up PR will update the types to beta

• Despite the tree is more optimal it is more complex than a linear search, and since the number of ServiceCIDRs is not expected to be large, use a linear search instead.
• Add tests for enable and disable the feature.
• Add metrics to record the latency.
• Evaluate performance
• Add dual-write feature gate to avoid duplicates ClusterIP on upgrades

Ref: kubernetes/enhancements#4645

KEP-1880: Users of the new feature to add multiple service CIDR will use by default a dual-write strategy on the new ClusterIP allocators to avoid the problem of possible duplicate IPs allocated to Services when running skewed kube-apiservers using different allocators. They can opt-out of this behavior by enabled the feature gate DisableAllocatorDualWrite

[k8s-ci-robot]

Please note that we're already in Test Freeze for the release-1.29 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.29.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sun Nov 26 10:00:25 UTC 2023.

[aojea]

/assign @danwinship @thockin

This remove the ip tree from the codebase

[k8s-triage-robot]

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

[thockin]

Thanks!

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: d749cf30427afc36c3b9c9de8c98826e8d11de3d

[aojea]

Thanks!

/lgtm /approve

failed the generated code , added in the last commit

[thockin]

Thanks!

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: b62d08ba49035d60f9a8a889e1406349ce6f1f8f

[k8s-triage-robot]

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

• The PR does have any do-not-merge/* labels
• The PR does not have the needs-ok-to-test label
• The PR is mergeable (does not have a needs-rebase label)
• The PR is approved (has cncf-cla: yes, lgtm, approved labels)
• The PR is failing tests required for merge

You can:

• Review the full test history for this PR
• Prevent this bot from retesting with /lgtm cancel or /hold
• Help make our tests less flaky by following our Flaky Tests Guide

/retest

[pacoxu]

/hold
for ci failure: Please run 'hack/update-openapi-spec.sh'

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, dgrisonnet, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• api/OWNERS [thockin]
• cmd/kube-apiserver/OWNERS [thockin]
• pkg/OWNERS [thockin]
• pkg/api/OWNERS [thockin]
• staging/src/k8s.io/api/OWNERS [thockin]
• test/OWNERS [aojea,thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aojea]

oh, I need to do make update, will push a new commit, @pacoxu do you

/hold for ci failure: Please run 'hack/update-openapi-spec.sh'

/hold cancel

I forget to update the openapi, added it in the last commit

@pacoxu do you mind to lgtm again? the code is the same just with this missing generated code

[pacoxu]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: b720c4c5e5b1b492c0e03789c74a125db003a867