Skip to content

Automated cherry pick of #112956: remove in-tree volume limits test now that CSIMigration is GA #112993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Nov 18, 2022
Merged

Automated cherry pick of #112956: remove in-tree volume limits test now that CSIMigration is GA #112993

k8s-ci-robot merged 1 commit into from
Nov 18, 2022

Conversation

@amacaskill
Copy link
Member

@amacaskill amacaskill commented Oct 11, 2022

Cherry pick of #112956 on release-1.25.

#112956: remove in-tree volume limits test now that CSIMigration is GA

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Oct 11, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 11, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 11, 2022

@amacaskill: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 11, 2022
@k8s-ci-robot k8s-ci-robot added area/test sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 11, 2022
@amacaskill
Copy link
Member Author

amacaskill commented Oct 11, 2022

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 11, 2022
@amacaskill
Copy link
Member Author

amacaskill commented Oct 11, 2022

/assign @msau42

@amacaskill amacaskill mentioned this pull request Oct 11, 2022
Merged
@liggitt
Copy link
Member

liggitt commented Oct 12, 2022

/lgtm
/approve

based on #112956 (comment)

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 12, 2022
@cici37
Copy link
Contributor

cici37 commented Oct 12, 2022

/lgtm
@kubernetes/release-managers

@Verolop
Copy link

Verolop commented Oct 12, 2022

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 12, 2022
@Verolop
Copy link

Verolop commented Oct 12, 2022

/lgtm

@Verolop Verolop added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 12, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 12, 2022
@Verolop Verolop removed the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 12, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 12, 2022
@cici37
Copy link
Contributor

cici37 commented Oct 12, 2022

From sig release: We are having a cherry pick deadline previous and it is still in effect now: https://groups.google.com/a/kubernetes.io/g/dev/c/P52OkdIA5jQ.

Thank you

@cici37
Copy link
Contributor

cici37 commented Nov 17, 2022

I think this one is ready since we are done with patch releases. @Verolop if you have time^^

xmudrii
xmudrii approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@xmudrii xmudrii added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 17, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Nov 17, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amacaskill, liggitt, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6c0bfe8 into kubernetes:release-1.25 Nov 18, 2022
This was referenced Jan 6, 2023
Merged
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xmudrii xmudrii xmudrii approved these changes

@gnufied gnufied Awaiting requested review from gnufied

@verult verult Awaiting requested review from verult

Assignees

@liggitt liggitt

@Verolop Verolop

@cici37 cici37

@xmudrii xmudrii

@msau42 msau42

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.25

Development

Successfully merging this pull request may close these issues.

7 participants

@amacaskill @k8s-ci-robot @liggitt @cici37 @Verolop @xmudrii @msau42