Skip to content

client-go: revert the refactor of retry#109149

Closed
tkashem wants to merge 6 commits intokubernetes:masterfrom
tkashem:revert-retry
Closed

client-go: revert the refactor of retry#109149
tkashem wants to merge 6 commits intokubernetes:masterfrom
tkashem:revert-retry

Conversation

@tkashem
Copy link
Contributor

@tkashem tkashem commented Mar 30, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

reverts refactor of retry logic with all dependencies

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

tkashem added 6 commits March 29, 2022 11:41
@tkashem
Revert "Merge pull request kubernetes#108698 from tkashem/last-error"
36faea5 
This reverts commit 5af9afe, reversing
changes made to ea006f5.
@tkashem
Revert "Merge pull request kubernetes#108347 from tkashem/refactor"
3e1751a 
This reverts commit 52cd4d5, reversing
changes made to 428ec84.
@tkashem
Revert "Merge pull request kubernetes#108342 from tkashem/rate-limit-…
d2b9928 
…error"

This reverts commit 7dde0b4, reversing
changes made to 9fbe66a.
@tkashem
Revert "Merge pull request kubernetes#108262 from tkashem/retry-unit-…
a743551 
…test"

This reverts commit 08d3285, reversing
changes made to 6d1c9a9.
@tkashem
Revert "Merge pull request kubernetes#102606 from tkashem/revert-102581"
418b5ae 
This reverts commit b429c4c, reversing
changes made to d59c065.
@tkashem
Revert "Merge pull request kubernetes#102217 from tkashem/client-go-r…
e1f3450 
…efactor-retry"

This reverts commit a898587, reversing
changes made to 77937b1.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 30, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 30, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tkashem
To complete the pull request process, please assign smarterclayton after the PR has been reviewed.
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 30, 2022
@tkashem tkashem changed the title Revert retry client-go: revert the refactor of retry Mar 30, 2022
@k8s-ci-robot k8s-ci-robot requested review from aojea and lojies March 30, 2022 12:09
@tkashem tkashem mentioned this pull request Mar 30, 2022
Merged
@tkashem
Copy link
Contributor Author

tkashem commented Mar 30, 2022

/assign @smarterclayton

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 30, 2022

@tkashem: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-node-e2e-containerd e1f3450 link true /test pull-kubernetes-node-e2e-containerd
pull-kubernetes-verify e1f3450 link true /test pull-kubernetes-verify
pull-kubernetes-integration e1f3450 link true /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tkashem
Copy link
Contributor Author

tkashem commented Mar 30, 2022

Clayton, after a deep review, confirmed that the retry logic did not break. https://github.com/kubernetes/kubernetes/pull/102217/files#r838569075

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 30, 2022

@tkashem: Closed this PR.

Details

In response to this:

Clayton, after a deep review, confirmed that the retry logic did not break. https://github.com/kubernetes/kubernetes/pull/102217/files#r838569075

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fedebongio
Copy link
Contributor

fedebongio commented Mar 31, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Mar 31, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aojea aojea Awaiting requested review from aojea

@lojies lojies Awaiting requested review from lojies

Assignees

@smarterclayton smarterclayton

Labels

area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tkashem @k8s-ci-robot @fedebongio @smarterclayton