-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webhooks,aggregation: add metrics to count certs with SHA1 signatures #109024
Conversation
Hi @stlaz. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/remove-priority critical-urgent |
7f5d2de
to
7829236
Compare
/test pull-kubernetes-integration |
@liggitt fyi |
staging/src/k8s.io/apiserver/pkg/util/x509metrics/missing_san.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiserver/pkg/util/x509metrics/missing_san.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
(from a metrics side)
staging/src/k8s.io/apiserver/pkg/util/x509metrics/missing_san.go
Outdated
Show resolved
Hide resolved
Extends the certificate attribute deprecation RoundTrippers wrapper with a checker that counts certificates with sha-1 signatures in server responses. Non-root non-self-signed SHA-1 certificate signatures were deprecated in Golang 1.18.
f1437c3
to
5479306
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I updated the release note to reference the go release notes, describe use of GODEBUG, the new metrics, and the kube-apiserver log. |
I also marked it as action-required |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Extends the certificate attribute deprecation RoundTrippers wrapper with
a checker that counts certificates with sha-1 signatures in server responses.
Non-root non-self-signed SHA-1 certificate signatures were deprecated in
Golang 1.18
Which issue(s) this PR fixes:
#108940
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
(this release note includes log and audit annotation prefixes added in #109107)
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: