Fail fast when image is specified without tag#101287
Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom Apr 21, 2021
Merged
Fail fast when image is specified without tag#101287k8s-ci-robot merged 2 commits intokubernetes:masterfrom
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
release-note-none
Contributor
Author
|
/sig testing |
k8s-ci-robot
added
sig/testing
Contributor
Author
|
/priority backlog |
k8s-ci-robot
added
priority/backlog
k8s-ci-robot
added
approved
test/utils/image/manifest.go
Outdated
Contributor
There was a problem hiding this comment.
Can we not just fix this and make the error be fail fast? It seems wierd that we'd allow pull specs without tags anywhere.
soltysh
force-pushed
the
replace_with_default
branch
from
33b7a64 to
431e8df
Compare
soltysh
changed the title
Contributor
There was a problem hiding this comment.
Yay, we caught a bug!
Member
There was a problem hiding this comment.
now do we need a test for a test util LOL (kidding)
Contributor
Author
There was a problem hiding this comment.
lol, I was considering that 😜
soltysh
force-pushed
the
replace_with_default
branch
from
431e8df to
3edabfb
Compare
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Currently when replacing images we assume an image is in the formimage:tagbut there are cases where this is not true. This PR defaults tag to:latestwhen not specified.This PR changes image replace code such that it requires
image:tagformat.Special notes for your reviewer:
/assign @smarterclayton
Does this PR introduce a user-facing change?