Skip to content

Commit

Permalink
Merge pull request #29785 from petemiron/patch-1
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue

Clarify documentation that new admission control plugin must be imported

```release-note
```

Admission control design doc doesn't mention importing the plugin to plugins.go. I was unable to get the plugin to build into my binary without it. Updated documentation to prevent future confusion.
  • Loading branch information
Kubernetes Submit Queue authored Aug 23, 2016
2 parents 6d6ce86 + f078f8d commit 8ba1be3
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions docs/design/admission_control.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,17 @@ func init() {
}
```

A **plug-in** must be added to the imports in [plugins.go](../../cmd/kube-apiserver/app/plugins.go)

```go
// Admission policies
_ "k8s.io/kubernetes/plugin/pkg/admission/admit"
_ "k8s.io/kubernetes/plugin/pkg/admission/alwayspullimages"
_ "k8s.io/kubernetes/plugin/pkg/admission/antiaffinity"
...
_ "<YOUR NEW PLUGIN>"
```

Invocation of admission control is handled by the **APIServer** and not
individual **RESTStorage** implementations.

Expand Down

0 comments on commit 8ba1be3

Please sign in to comment.